-
Notifications
You must be signed in to change notification settings - Fork 222
TypeScript declarations #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi, @TiagoCavalcante |
That rollup config assumes the project is written in TypeScript. |
@CodyJasonBennett my plan was to change all extensions to ts and fix the errors, but if you prefer I can add JSDoc. Out of the file declarations are error prone. So what do you prefer? |
1 similar comment
@CodyJasonBennett my plan was to change all extensions to ts and fix the errors, but if you prefer I can add JSDoc. Out of the file declarations are error prone. So what do you prefer? |
I'd have to defer this to #24 where this was already discussed. |
I didn't read that before, I'll only do it when you are sure if you want TS, I don't want to work on a rejected PR. |
There are currently at least one TS fork of the library #24 (comment) |
I think the OP is more about the declarations rather than the code itself being written in TypeScript? Here's the thread on what three.js has done for comparison: |
I think that TypeScript declarations are very important for any npm library, with TS 4.6 it can be done mostly automatically.
You can follow the
rollup.config.js
andtsconfig.json
of this repo to generate the .d.ts files.The text was updated successfully, but these errors were encountered: