-
Notifications
You must be signed in to change notification settings - Fork 31
Zap dead code #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zap dead code #798
Conversation
It looks like the debops CI tool is not happy that
We should figure out how to teach it that we don't need that package anymore. |
I have a patch for this inside of ooni/sysadmin#511 |
This commit should be reverted prior to merge (see 🔄 emoji 🙃)
Ok we are all green, except for the integration tests, which are failing because of the changes to the public list measurements API that are part of the parent PR. I plan to fix those tests as part of that separate PR. This branch is ready for review. |
Summary of changes: * Ignore rebuilding of debian packages that have been deleted * Add `--dry-run` CLI option to make it easier to locally test As noted inside of ooni/backend#798, debops-ci will attempt to build a package even when the package has been deleted. This happens because it will rebuild any package that it detects by running: ``` git diff --name-only {commit} ``` and filtering by those names that match the string `debian/changelog`. However, since it's not filtering by the status, which could also be that the `debian/changelog` had been deleted, it thinks it should rebuild also a deleted package. In this patch I fix that, by ignoring any paths that have the `D` (deleted) status. I also add support for a `--dry-run` command line flag, allowing you to better debug what's going on in non-debian systems.
As part of this PR, everything that is dead code, is removed from the source tree.
This includes:
af/
-> this was the old airflow postgresql related codeold_backend/
-> this was the super old pre-2016 twisted based backenddocs/
-> contained documentation about the ~2016 data pipelineReadme.md
-> Still talks about some super old stuffrate_limit_quotas.py
-> duplicate of file insideooniapi/rate_limit_quotas.py
ooniapi/scripts
-> these scripts expect a postgresql database, which doesn't exist anymoreapi/refresh_deps
-> non-existent files are referenced in itmarkdown/*
-> these docs are not used anywhere and are superseeded by the swagger based docs