Skip to content

refactor: refine typing.Any type hints #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025

Conversation

gruebel
Copy link
Member

@gruebel gruebel commented May 31, 2025

This PR

  • replaced most of the Any type usage with proper types

@gruebel gruebel requested review from a team as code owners May 31, 2025 22:13
Copy link

codecov bot commented May 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.65%. Comparing base (87e4485) to head (449460a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
+ Coverage   97.44%   97.65%   +0.20%     
==========================================
  Files          37       37              
  Lines        1761     1788      +27     
==========================================
+ Hits         1716     1746      +30     
+ Misses         45       42       -3     
Flag Coverage Δ
unittests 97.65% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gruebel gruebel merged commit f95b27a into open-feature:main Jun 3, 2025
15 checks passed
@gruebel gruebel deleted the refine-type-hints branch June 3, 2025 17:52
Copy link
Contributor

@leohoare leohoare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants