Skip to content

Commit 1e2e97c

Browse files
authored
Merge pull request #10992 from devreal/fix-han-dynamic-rules-cid1516459
Fix access after free in han dynamic rules parser (CID 1516459)
2 parents 2c865d9 + 3623699 commit 1e2e97c

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

ompi/mca/coll/han/coll_han_dynamic_file.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,9 +375,10 @@ mca_coll_han_init_dynamic_rules(void)
375375
if (algorithm_id < 0) {
376376
char *endp;
377377
algorithm_id = (int)strtol(algorithm_name, &endp, 10);
378+
char endc = *endp;
378379
free(algorithm_name);
379380
algorithm_name = NULL;
380-
if (('\0' != *endp ) || !mca_coll_han_algorithm_id_is_valid(coll_id, algorithm_id)) {
381+
if (('\0' != endc ) || !mca_coll_han_algorithm_id_is_valid(coll_id, algorithm_id)) {
381382
opal_output_verbose(5, mca_coll_han_component.han_output,
382383
"coll:han:mca_coll_han_init_dynamic_rules found an error on dynamic rules file %s "
383384
"at line %d: unknown algorithm '%s' for %s\n",

0 commit comments

Comments
 (0)