Fixing missing lock release in mca_pml_ob1_record_htod_event

David Wootton · David Wootton · commit 2c5429d68bc8 · 2022-12-12T15:17:59.000-05:00
Coverity CID 1515766

Signed-off-by: David Wootton &lt;dwootton@us.ibm.com&gt;
diff --git a/ompi/mca/pml/ob1/pml_ob1_accelerator.c b/ompi/mca/pml/ob1/pml_ob1_accelerator.c
@@ -90,6 +90,7 @@ int mca_pml_ob1_record_htod_event(char *msg, struct mca_btl_base_descriptor_t *f
     if (accelerator_event_htod_num_used == accelerator_event_max) {
         opal_output_verbose(1, mca_pml_ob1_output, "Out of event handles. Max: %d. Suggested to rerun with new max with --mca mpi_common_accelerator_event_max %d.",
                             accelerator_event_max, accelerator_event_max + 100);
+        OPAL_THREAD_UNLOCK(&pml_ob1_accelerator_htod_lock);
         return OPAL_ERR_OUT_OF_RESOURCE;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,7 @@ int mca_pml_ob1_record_htod_event(char msg, struct mca_btl_base_descriptor_t f`
`90`	`90`	`if (accelerator_event_htod_num_used == accelerator_event_max) {`
`91`	`91`	`opal_output_verbose(1, mca_pml_ob1_output, "Out of event handles. Max: %d. Suggested to rerun with new max with --mca mpi_common_accelerator_event_max %d.",`
`92`	`92`	`accelerator_event_max, accelerator_event_max + 100);`
	`93`	`+ OPAL_THREAD_UNLOCK(&pml_ob1_accelerator_htod_lock);`
`93`	`94`	`return OPAL_ERR_OUT_OF_RESOURCE;`
`94`	`95`	`}`
`95`	`96`