Skip to content

Commit 49a28d3

Browse files
jjhurseyrhc54
authored andcommitted
Initialize pmix_info_t flags when loading
* Leaving the `flags` variable uninitialized can cause it to take a value that leads to misbehavior when handling PMIx_Get. * Detected by running an IBM XL compiler build of PRRTE in which sometimes the PMIx_Get would turns the value requested and sometimes not depending on the memory placmeent of the allocated pmix_info_t. Signed-off-by: Joshua Hursey <[email protected]>
1 parent e11fe2a commit 49a28d3

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/mca/bfrops/base/bfrop_base_fns.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
* Copyright (c) 2019 Mellanox Technologies, Inc.
1414
* All rights reserved.
1515
* Copyright (c) 2021-2022 Nanook Consulting All rights reserved.
16+
* Copyright (c) 2022 IBM Corporation. All rights reserved.
1617
* $COPYRIGHT$
1718
*
1819
* Additional copyrights may follow
@@ -68,6 +69,7 @@ PMIX_EXPORT pmix_status_t PMIx_Info_load(pmix_info_t *info,
6869
return PMIX_ERR_BAD_PARAM;
6970
}
7071
PMIX_LOAD_KEY(info->key, key);
72+
info->flags = 0;
7173
return PMIx_Value_load(&info->value, data, type);
7274
}
7375

0 commit comments

Comments
 (0)