Apply suggestions from code review

Co-authored-by: Joseph Schuchart <[email protected]>
Signed-off-by: bosilca <[email protected]>

Author: bosilca

opal/mca/btl/tcp/btl_tcp_component.c

@@ -1512,7 +1512,7 @@ static void mca_btl_tcp_component_recv_handler(int sd, short flags, void *user)
              * but that interface is only local, and we received our own message.
              * If we just close the socket this will confuse the connection, as
              * it will not be able to know that the interface should not be
-             * used. Instead, we cabn identify ourselves by sending our guid
+             * used. Instead, we can identify ourselves by sending our guid
              * back to ourselves, marking the interface as improper for future
              * communications.
              */

opal/mca/btl/tcp/btl_tcp_proc.c

@@ -410,8 +410,8 @@ mca_btl_tcp_proc_t *mca_btl_tcp_proc_create(opal_proc_t *proc)
     }
 
     /**
-     * If the peer is physically located on another node, remove allinterfaces
-     * that have the an IP address identical to any local interface (this will
+     * If the peer is physically located on another node, remove all interfaces
+     * that have an IP address identical to any local interface (this will
      * remove all the local and virtual interfaces).
      */
     size_t count = size / sizeof(mca_btl_tcp_modex_addr_t);
@@ -423,9 +423,9 @@ mca_btl_tcp_proc_t *mca_btl_tcp_proc_create(opal_proc_t *proc)
             OPAL_LIST_FOREACH (local_iter, local_ifs, opal_if_t) {
                 if (MCA_BTL_TCP_AF_INET == remote_addrs[i].addr_family &&
                     AF_INET == local_iter->af_family) {
-                    if (!memcmp(&((struct sockaddr_in *)&local_iter->if_addr)->sin_addr,
-                                remote_addrs[i].addr,
-                                sizeof(struct in_addr))) {
+                    if (0 == memcmp(&((struct sockaddr_in *)&local_iter->if_addr)->sin_addr,
+                                    remote_addrs[i].addr,
+                                    sizeof(struct in_addr))) {
                         /* we found a match */
                         inet_ntop(AF_INET, remote_addrs[i].addr, tmp[0], 16);
                         inet_ntop(AF_INET, &((struct sockaddr_in *) &local_iter->if_addr)->sin_addr,
@@ -436,9 +436,9 @@ mca_btl_tcp_proc_t *mca_btl_tcp_proc_create(opal_proc_t *proc)
 #if OPAL_ENABLE_IPV6
                 else if (MCA_BTL_TCP_AF_INET6 == remote_addrs[i].addr_family &&
                          AF_INET6 == local_iter->af_family) {
-                    if (!memcmp(&((struct sockaddr_in6 *) &local_iter->if_addr)->sin6_addr,
-                                remote_addrs[i].addr,
-                                sizeof(struct in6_addr))) {
+                    if (0 == memcmp(&((struct sockaddr_in6 *) &local_iter->if_addr)->sin6_addr,
+                                    remote_addrs[i].addr,
+                                    sizeof(struct in6_addr))) {
                         /* we found a match */
                         inet_ntop(AF_INET6, remote_addrs[i].addr, tmp[0], 16);
                         inet_ntop(AF_INET6, &((struct sockaddr_in6 *) &local_iter->if_addr)->sin6_addr,