Skip to content

Commit bcf20a6

Browse files
author
Sergey Oblomov
committed
COMMON/UCX: suppressed coverity warnings
- suppressed coverity warnings - added log messages on failed calls Signed-off-by: Sergey Oblomov <[email protected]> (cherry picked from commit df76559)
1 parent 6c18cb1 commit bcf20a6

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

ompi/mca/osc/ucx/osc_ucx_active_target.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,9 @@ int ompi_osc_ucx_complete(struct ompi_win_t *win) {
193193
OSC_UCX_VERBOSE(1, "ucp_atomic_post failed: %d", status);
194194
}
195195

196-
opal_common_ucx_ep_flush(ep, mca_osc_ucx_component.ucp_worker);
196+
if (OMPI_SUCCESS != opal_common_ucx_ep_flush(ep, mca_osc_ucx_component.ucp_worker)) {
197+
OSC_UCX_VERBOSE(1, "opal_common_ucx_ep_flush failed");
198+
}
197199
}
198200

199201
OBJ_RELEASE(module->start_group);

ompi/mca/osc/ucx/osc_ucx_component.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -822,7 +822,9 @@ int ompi_osc_ucx_free(struct ompi_win_t *win) {
822822
ucp_worker_progress(mca_osc_ucx_component.ucp_worker);
823823
}
824824

825-
opal_common_ucx_worker_flush(mca_osc_ucx_component.ucp_worker);
825+
if (OMPI_SUCCESS != opal_common_ucx_worker_flush(mca_osc_ucx_component.ucp_worker)) {
826+
OSC_UCX_VERBOSE(1, "opal_common_ucx_worker_flush failed");
827+
}
826828

827829
ret = module->comm->c_coll->coll_barrier(module->comm,
828830
module->comm->c_coll->coll_barrier_module);

opal/mca/common/ucx/common_ucx.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,12 @@ OPAL_DECLSPEC void opal_common_ucx_mca_register(void)
8989
opal_common_ucx.output = opal_output_open(NULL);
9090
opal_output_set_verbosity(opal_common_ucx.output, opal_common_ucx.verbose);
9191

92-
mca_base_framework_open(&opal_memory_base_framework, 0);
92+
if (OPAL_SUCCESS != mca_base_framework_open(&opal_memory_base_framework, 0)) {
93+
/* failed to initialize memory framework - just exit */
94+
MCA_COMMON_UCX_VERBOSE(1, "%s", "failed to initialize memory base framework, "
95+
"memory hooks will not be used");
96+
return;
97+
}
9398

9499
/* Set memory hooks */
95100
if (opal_common_ucx.opal_mem_hooks &&

0 commit comments

Comments
 (0)