request: Fix multiple calls to ompi_request_complete()

dalcinl · dalcinl · commit d2242681e264 · 2024-03-06T13:24:12.000+03:00
A second call to ompi_request_complete() segfaults. Make it mostly an
non-op. Alternatively, the second invocation could generate an error, but
let's play safe for now.

Signed-off-by: Lisandro Dalcin &lt;dalcinl@gmail.com&gt;
diff --git a/ompi/request/request.h b/ompi/request/request.h
@@ -532,7 +532,7 @@ static inline int ompi_request_complete(ompi_request_t* request, bool with_signa
 
             ompi_wait_sync_t *tmp_sync = (ompi_wait_sync_t *) OPAL_ATOMIC_SWAP_PTR(&request->req_complete,
                                                                                     REQUEST_COMPLETED);
-            if( REQUEST_PENDING != tmp_sync ) {
+            if (REQUEST_PENDING != tmp_sync && REQUEST_COMPLETED != tmp_sync) {
                 wait_sync_update(tmp_sync, 1, request->req_status.MPI_ERROR);
             }
         } else {

Original file line number	Diff line number	Diff line change
`@@ -532,7 +532,7 @@ static inline int ompi_request_complete(ompi_request_t* request, bool with_signa`
`532`	`532`
`533`	`533`	`ompi_wait_sync_t tmp_sync = (ompi_wait_sync_t ) OPAL_ATOMIC_SWAP_PTR(&request->req_complete,`
`534`	`534`	`REQUEST_COMPLETED);`
`535`		`- if( REQUEST_PENDING != tmp_sync ) {`
	`535`	`+ if (REQUEST_PENDING != tmp_sync && REQUEST_COMPLETED != tmp_sync) {`
`536`	`536`	`wait_sync_update(tmp_sync, 1, request->req_status.MPI_ERROR);`
`537`	`537`	`}`
`538`	`538`	`} else {`