Skip to content

Merge Fortran ERRCODES_IGNORE fix to v2.x, v3.0.x, v3.x #4693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsquyres opened this issue Jan 10, 2018 · 1 comment
Closed

Merge Fortran ERRCODES_IGNORE fix to v2.x, v3.0.x, v3.x #4693

jsquyres opened this issue Jan 10, 2018 · 1 comment

Comments

@jsquyres
Copy link
Member

@nathanweeks submitted an F08 ERRCODES_IGNORE fix to master in #4681.

It needs to be applied to:

  • v2.x
  • v3.0.x
  • v3.1.x

On the one hand, I'd like to apply the fix to v2.0.x even if we never release from there again. But OTOH, there's a pretty small barrier-to-entry from moving from v2.0.x to v2.1.x. So I think: let's not apply it to v2.0.x as an encouragement for people to upgrade to (at least) v2.1.x.

NOTE: This is another issue that breaks backwards compatibility for F08. However, as noted on #4681, correct MPI programs could not compile because of this bug. Hence, this is an issue where we should fix it, note that we broke backwards compatibility (because the user app must have been incorrect if it had been able to compile before) in README, and move ok.

Are the v2.x and v3.x RMs ok with this?

@bwbarrett
Copy link
Member

@jsquyres, can we close this bug now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants