From 3623699ad27dd8c329521fc08ba105df0aab6f58 Mon Sep 17 00:00:00 2001 From: Joseph Schuchart Date: Thu, 27 Oct 2022 10:01:02 -0400 Subject: [PATCH] Fix access after free in han dynamic rules parser (CID 1516459) Signed-off-by: Joseph Schuchart --- ompi/mca/coll/han/coll_han_dynamic_file.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ompi/mca/coll/han/coll_han_dynamic_file.c b/ompi/mca/coll/han/coll_han_dynamic_file.c index 6e041829a5f..dc118ddd31c 100644 --- a/ompi/mca/coll/han/coll_han_dynamic_file.c +++ b/ompi/mca/coll/han/coll_han_dynamic_file.c @@ -375,9 +375,10 @@ mca_coll_han_init_dynamic_rules(void) if (algorithm_id < 0) { char *endp; algorithm_id = (int)strtol(algorithm_name, &endp, 10); + char endc = *endp; free(algorithm_name); algorithm_name = NULL; - if (('\0' != *endp ) || !mca_coll_han_algorithm_id_is_valid(coll_id, algorithm_id)) { + if (('\0' != endc ) || !mca_coll_han_algorithm_id_is_valid(coll_id, algorithm_id)) { opal_output_verbose(5, mca_coll_han_component.han_output, "coll:han:mca_coll_han_init_dynamic_rules found an error on dynamic rules file %s " "at line %d: unknown algorithm '%s' for %s\n",