refactor(sdk-trace-base): update semconv usage to ATTR_ exports (#5669)

Author: trentm

CHANGELOG.md

@@ -28,6 +28,7 @@ For notes on migrating to 2.x / 0.200.x see [the upgrade guide](doc/upgrade-to-2
 
 ### :house: Internal
 
+* refactor(sdk-trace-base): update semconv usage to ATTR_ exports [#5669](https://github.com/open-telemetry/opentelemetry-js/pull/5669) @trentm
 * refactor(sdk-trace-web): update semconv usage to ATTR_ exports [#5672](https://github.com/open-telemetry/opentelemetry-js/pull/5672) @trentm
 * refactor(resources): update semconv usage to ATTR_ exports [#5666](https://github.com/open-telemetry/opentelemetry-js/pull/5666) @trentm
 * test(sdk-metrics): fix multiple problematic assertRejects() calls [#5611](https://github.com/open-telemetry/opentelemetry-js/pull/5611) @cjihrig

packages/opentelemetry-sdk-trace-base/src/Span.ts

@@ -44,9 +44,9 @@ import {
 } from '@opentelemetry/core';
 import { Resource } from '@opentelemetry/resources';
 import {
-  SEMATTRS_EXCEPTION_MESSAGE,
-  SEMATTRS_EXCEPTION_STACKTRACE,
-  SEMATTRS_EXCEPTION_TYPE,
+  ATTR_EXCEPTION_MESSAGE,
+  ATTR_EXCEPTION_STACKTRACE,
+  ATTR_EXCEPTION_TYPE,
 } from '@opentelemetry/semantic-conventions';
 import { ReadableSpan } from './export/ReadableSpan';
 import { ExceptionEventName } from './enums';
@@ -330,26 +330,23 @@ export class SpanImpl implements Span {
   recordException(exception: Exception, time?: TimeInput): void {
     const attributes: Attributes = {};
     if (typeof exception === 'string') {
-      attributes[SEMATTRS_EXCEPTION_MESSAGE] = exception;
+      attributes[ATTR_EXCEPTION_MESSAGE] = exception;
     } else if (exception) {
       if (exception.code) {
-        attributes[SEMATTRS_EXCEPTION_TYPE] = exception.code.toString();
+        attributes[ATTR_EXCEPTION_TYPE] = exception.code.toString();
       } else if (exception.name) {
-        attributes[SEMATTRS_EXCEPTION_TYPE] = exception.name;
+        attributes[ATTR_EXCEPTION_TYPE] = exception.name;
       }
       if (exception.message) {
-        attributes[SEMATTRS_EXCEPTION_MESSAGE] = exception.message;
+        attributes[ATTR_EXCEPTION_MESSAGE] = exception.message;
       }
       if (exception.stack) {
-        attributes[SEMATTRS_EXCEPTION_STACKTRACE] = exception.stack;
+        attributes[ATTR_EXCEPTION_STACKTRACE] = exception.stack;
       }
     }
 
     // these are minimum requirements from spec
-    if (
-      attributes[SEMATTRS_EXCEPTION_TYPE] ||
-      attributes[SEMATTRS_EXCEPTION_MESSAGE]
-    ) {
+    if (attributes[ATTR_EXCEPTION_TYPE] || attributes[ATTR_EXCEPTION_MESSAGE]) {
       this.addEvent(ExceptionEventName, attributes, time);
     } else {
       diag.warn(`Failed to record an exception ${exception}`);

packages/opentelemetry-sdk-trace-base/test/common/Span.test.ts

@@ -33,9 +33,9 @@ import {
   otperformance as performance,
 } from '@opentelemetry/core';
 import {
-  SEMATTRS_EXCEPTION_MESSAGE,
-  SEMATTRS_EXCEPTION_STACKTRACE,
-  SEMATTRS_EXCEPTION_TYPE,
+  ATTR_EXCEPTION_MESSAGE,
+  ATTR_EXCEPTION_STACKTRACE,
+  ATTR_EXCEPTION_TYPE,
 } from '@opentelemetry/semantic-conventions';
 import * as assert from 'assert';
 import * as sinon from 'sinon';
@@ -1439,10 +1439,10 @@ describe('Span', () => {
 
           assert.ok(event.attributes);
 
-          const type = event.attributes[SEMATTRS_EXCEPTION_TYPE];
-          const message = event.attributes[SEMATTRS_EXCEPTION_MESSAGE];
+          const type = event.attributes[ATTR_EXCEPTION_TYPE];
+          const message = event.attributes[ATTR_EXCEPTION_MESSAGE];
           const stacktrace = String(
-            event.attributes[SEMATTRS_EXCEPTION_STACKTRACE]
+            event.attributes[ATTR_EXCEPTION_STACKTRACE]
           );
           assert.strictEqual(type, 'Error');
           assert.strictEqual(message, 'boom');
@@ -1488,7 +1488,7 @@ describe('Span', () => {
         span.recordException({ code: 12 });
         const event = span.events[0];
         assert.deepStrictEqual(event.attributes, {
-          [SEMATTRS_EXCEPTION_TYPE]: '12',
+          [ATTR_EXCEPTION_TYPE]: '12',
         });
       });
     });