Add tests

Author: dbanty

openapi_python_client/parser/openapi.py

@@ -388,7 +388,7 @@ def from_data(
         else:
             name = data.operationId
 
-        result: Union[Endpoint, ParseError] = Endpoint(
+        endpoint = Endpoint(
             path=path,
             method=method,
             summary=utils.remove_string_escapes(data.summary) if data.summary else "",
@@ -398,11 +398,8 @@ def from_data(
             tag=tag,
         )
 
-        if isinstance(result, ParseError):
-            return result, schemas, parameters
-
         result, schemas, parameters = Endpoint.add_parameters(
-            endpoint=result,
+            endpoint=endpoint,
             data=data,
             schemas=schemas,
             parameters=parameters,

tests/test_parser/test_bodies.py

@@ -0,0 +1,39 @@
+from openapi_python_client import Config
+from openapi_python_client import schema as oai
+from openapi_python_client.parser.bodies import body_from_data
+from openapi_python_client.parser.errors import ParseError
+from openapi_python_client.parser.properties import Schemas
+
+
+def test_errors():
+    operation = oai.Operation(
+        requestBody=oai.RequestBody(
+            content={
+                "invalid content type": oai.MediaType(
+                    media_type_schema=oai.Schema(
+                        type=oai.DataType.STRING,
+                    )
+                ),
+                "application/json": oai.MediaType(
+                    media_type_schema=None  # Missing media type schema is an error
+                ),
+                "text/html": oai.MediaType(  # content type not supported by the generator
+                    media_type_schema=oai.Schema(
+                        type=oai.DataType.STRING,
+                    )
+                ),
+                "application/sushi+json": oai.MediaType(
+                    media_type_schema=oai.Schema(
+                        type=oai.DataType.INTEGER,
+                        default="make this an invalid property",
+                    )
+                ),
+            }
+        ),
+        responses={},
+    )
+
+    errs, _ = body_from_data(data=operation, schemas=Schemas(), config=Config(), endpoint_name="this will not succeed")
+
+    assert len(errs) == len(operation.request_body.content)
+    assert all(isinstance(err, ParseError) for err in errs)

tests/test_parser/test_openapi.py

@@ -8,6 +8,7 @@
 from openapi_python_client.parser.errors import ParseError
 from openapi_python_client.parser.openapi import Endpoint, EndpointCollection
 from openapi_python_client.parser.properties import IntProperty, Parameters, Schemas
+from openapi_python_client.schema import DataType
 
 MODULE_NAME = "openapi_python_client.parser.openapi"
 
@@ -874,6 +875,49 @@ def test_from_data_no_security(self, mocker):
             config=config,
         )
 
+    def test_from_data_some_bad_bodies(self):
+        endpoint, _, _ = Endpoint.from_data(
+            data=oai.Operation(
+                responses={},
+                requestBody=oai.RequestBody(
+                    content={
+                        "application/json": oai.MediaType(media_type_schema=oai.Schema(type=DataType.STRING)),
+                        "not a real media type": oai.MediaType(media_type_schema=oai.Schema(type=DataType.STRING)),
+                    },
+                ),
+            ),
+            schemas=Schemas(),
+            config=Config(),
+            parameters=Parameters(),
+            tag="tag",
+            path="/",
+            method="get",
+        )
+
+        assert isinstance(endpoint, Endpoint)
+        assert len(endpoint.bodies) == 1
+        assert len(endpoint.errors) == 1
+
+    def test_from_data_all_bodies_bad(self):
+        endpoint, _, _ = Endpoint.from_data(
+            data=oai.Operation(
+                responses={},
+                requestBody=oai.RequestBody(
+                    content={
+                        "not a real media type": oai.MediaType(media_type_schema=oai.Schema(type=DataType.STRING)),
+                    },
+                ),
+            ),
+            schemas=Schemas(),
+            config=Config(),
+            parameters=Parameters(),
+            tag="tag",
+            path="/",
+            method="get",
+        )
+
+        assert isinstance(endpoint, ParseError)
+
     @pytest.mark.parametrize(
         "response_types, expected",
         (([], "Any"), (["Something"], "Something"), (["First", "Second", "Second"], "Union[First, Second]")),