Skip to content

Add Documentation for using POST requests with client #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danaelhe opened this issue Apr 16, 2021 · 2 comments
Closed

Add Documentation for using POST requests with client #391

danaelhe opened this issue Apr 16, 2021 · 2 comments
Labels
✨ enhancement New feature or improvement

Comments

@danaelhe
Copy link

danaelhe commented Apr 16, 2021

Describe the solution you'd like
Could you provide other request examples (besides just GET) either in the repo or generated in the docs?

@danaelhe danaelhe added the ✨ enhancement New feature or improvement label Apr 16, 2021
@dbanty
Copy link
Collaborator

dbanty commented Apr 16, 2021

Hi @danaelhe ! There shouldn't be any significant difference between how generated functions work. Which HTTP method is used, how the payload is serialized, where the parameters are put (path vs query), all of that should be abstracted away by the generator. Regardless of how it's working under the hood, it should be the_operations_name.sync() (or the async/_detailed variants).

I think we definitely need a full example somewhere of an OpenAPI document and the resulting generated code describing how each piece works... and I have a long-overdue issue #47 to build such a tutorial... it's just gotten buried under the pile of enhancements 😅.

Until we get that full tutorial written, is there something specific in the existing documentation that was confusing to you? Should we rename the example function in the generated README.md so it doesn't use the word "get"? I'd love to make this project easier to get started with, but won't have the bandwidth for the full tutorial for some time 😞

@danaelhe
Copy link
Author

Thanks for that thoughtful response! I'll try to contribute that back when I find time myself :)

It's a great tool btw! I like it more than the other generators out there.

@dbanty dbanty closed this as not planned Won't fix, can't repro, duplicate, stale Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or improvement
Projects
None yet
Development

No branches or pull requests

2 participants