Skip to content

Commit 4aed65f

Browse files
committed
openapi-processor/openapi-processor-spring#150, replace generic names with generic types
1 parent ea5c261 commit 4aed65f

File tree

2 files changed

+15
-18
lines changed

2 files changed

+15
-18
lines changed

openapi-processor-core/src/main/kotlin/io/openapiprocessor/core/processor/mapping/v1/MappingConverter.kt

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,7 @@
1616

1717
package io.openapiprocessor.core.processor.mapping.v1
1818

19-
import io.openapiprocessor.core.converter.mapping.AddParameterTypeMapping
20-
import io.openapiprocessor.core.converter.mapping.EndpointTypeMapping
21-
import io.openapiprocessor.core.converter.mapping.ParameterTypeMapping
22-
import io.openapiprocessor.core.converter.mapping.ResponseTypeMapping
23-
import io.openapiprocessor.core.converter.mapping.ResultTypeMapping
24-
import io.openapiprocessor.core.converter.mapping.TypeMapping
25-
import io.openapiprocessor.core.converter.mapping.Mapping
19+
import io.openapiprocessor.core.converter.mapping.*
2620

2721
import io.openapiprocessor.core.processor.mapping.v1.Mapping as MappingV1
2822

@@ -94,7 +88,8 @@ class MappingConverter {
9488
generics = type.generics
9589
}
9690

97-
return TypeMapping(from, format, to, generics)
91+
val genericTypes = generics.map { TargetType(it) }
92+
return TypeMapping(from, format, to, emptyList(), genericTypes)
9893
}
9994

10095
private fun convertResult(result: Result): Mapping {

openapi-processor-core/src/test/groovy/com/github/hauner/openapi/core/processor/MappingConverterSpec.groovy

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ map:
5757
type.sourceTypeName == 'array'
5858
type.sourceTypeFormat == null
5959
type.targetTypeName == 'java.util.Collection'
60-
type.genericTypeNames == []
60+
type.genericTypes == []
6161
}
6262

6363
void "reads global type mapping with generic types" () {
@@ -89,13 +89,15 @@ map:
8989
shortFormat.sourceTypeName == 'Foo'
9090
shortFormat.sourceTypeFormat == null
9191
shortFormat.targetTypeName == 'mapping.Bar'
92-
shortFormat.genericTypeNames == ['java.lang.String', 'java.lang.Boolean']
92+
shortFormat.genericTypes[0].typeName == 'java.lang.String'
93+
shortFormat.genericTypes[1].typeName == 'java.lang.Boolean'
9394

9495
def longFormat = mappings[1] as TypeMapping
9596
longFormat.sourceTypeName == 'Foo2'
9697
longFormat.sourceTypeFormat == null
9798
longFormat.targetTypeName == 'mapping.Bar2'
98-
longFormat.genericTypeNames == ['java.lang.String2', 'java.lang.Boolean2']
99+
longFormat.genericTypes[0].typeName == 'java.lang.String2'
100+
longFormat.genericTypes[1].typeName == 'java.lang.Boolean2'
99101
}
100102

101103
void "reads global type mapping with format" () {
@@ -118,7 +120,7 @@ map:
118120
type.sourceTypeName == 'string'
119121
type.sourceTypeFormat == 'date-time'
120122
type.targetTypeName == 'java.time.ZonedDateTime'
121-
type.genericTypeNames == []
123+
type.genericTypes == []
122124
}
123125

124126
void "reads global response type mapping" () {
@@ -143,7 +145,7 @@ map:
143145
response.mapping.sourceTypeName == null
144146
response.mapping.sourceTypeFormat == null
145147
response.mapping.targetTypeName == 'java.util.List'
146-
response.mapping.genericTypeNames == []
148+
response.mapping.genericTypes == []
147149
}
148150

149151
void "reads endpoint response type mapping" () {
@@ -174,7 +176,7 @@ map:
174176
response.mapping.sourceTypeName == null
175177
response.mapping.sourceTypeFormat == null
176178
response.mapping.targetTypeName == 'java.util.List'
177-
response.mapping.genericTypeNames == []
179+
response.mapping.genericTypes == []
178180
}
179181

180182
void "reads global parameter type mapping" () {
@@ -199,7 +201,7 @@ map:
199201
parameter.mapping.sourceTypeName == null
200202
parameter.mapping.sourceTypeFormat == null
201203
parameter.mapping.targetTypeName == 'mapping.Foo'
202-
parameter.mapping.genericTypeNames == []
204+
parameter.mapping.genericTypes == []
203205
}
204206

205207
void "reads endpoint parameter type mapping" () {
@@ -229,7 +231,7 @@ map:
229231
parameter.mapping.sourceTypeName == null
230232
parameter.mapping.sourceTypeFormat == null
231233
parameter.mapping.targetTypeName == 'mapping.Foo'
232-
parameter.mapping.genericTypeNames == []
234+
parameter.mapping.genericTypes == []
233235
}
234236

235237
void "reads endpoint type mapping" () {
@@ -259,7 +261,7 @@ map:
259261
type.sourceTypeName == 'array'
260262
type.sourceTypeFormat == null
261263
type.targetTypeName == 'java.util.Collection'
262-
type.genericTypeNames == []
264+
type.genericTypes == []
263265
}
264266

265267
void "reads endpoint add mapping" () {
@@ -293,7 +295,7 @@ map:
293295
parameter.mapping.sourceTypeName == null
294296
parameter.mapping.sourceTypeFormat == null
295297
parameter.mapping.targetTypeName == 'javax.servlet.http.HttpServletRequest'
296-
parameter.mapping.genericTypeNames == []
298+
parameter.mapping.genericTypes == []
297299
}
298300

299301
void "reads endpoint exclude flag" () {

0 commit comments

Comments
 (0)