Skip to content

Doesn't work on non-standard ports #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
macroexp opened this issue Jun 3, 2020 · 2 comments
Closed

Doesn't work on non-standard ports #267

macroexp opened this issue Jun 3, 2020 · 2 comments

Comments

@macroexp
Copy link

macroexp commented Jun 3, 2020

At least on macOS platform, running node v14.3.0, using a url such as http://192.168.7.245:8091/doc/swagger/swagger.yaml results in an error "Error: getaddrinfo ENOTFOUND 192.168.7.245:8091" - clearly, some code that is attempting to split the url up is not splitting the port off the host part before doing a lookup.
@selbekk selbekk mentioned this issue Jul 23, 2020
Closed
@selbekk
Copy link
Contributor

selbekk commented Jul 23, 2020

Yeah same here. Created a PR to fix it :)

@drwpow
Copy link
Contributor

drwpow commented Aug 8, 2020

This is fixed in #252. Will go out in the next release

@drwpow drwpow closed this as completed Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for non-standard ports selbekk/swagger-to-ts
3 participants
@selbekk @drwpow @macroexp