Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Do we still need all the representations of sequence lengths in DataSource? #219

Open
Tracked by #213
JackKelly opened this issue Oct 12, 2021 · 0 comments
Open
Tracked by #213

Do we still need all the representations of sequence lengths in DataSource? #219

JackKelly opened this issue Oct 12, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers refactoring

Comments

@JackKelly
Copy link
Member

JackKelly commented Oct 12, 2021 •
edited
Loading

After #213 is implemented, we should check to see if DataSource really needs history_len, forecast_len, _total_seq_len, _total_seq_dur, _history_dur and _forecast_dur. It's possible that some are no longer needed 🙂

_total_seq_len is used to define self._shape_of_example in NWPDataSource.__post_init__ and SatelliteDataSource.__post_init__
@JackKelly JackKelly added enhancement New feature or request refactoring labels Oct 12, 2021
@JackKelly JackKelly changed the title Do we still need all the representations of sequence lenghts in DataSource? Do we still need all the representations of sequence lengths in DataSource? Oct 12, 2021
@JackKelly JackKelly mentioned this issue Oct 12, 2021
Closed
38 tasks
@JackKelly JackKelly added the good first issue Good for newcomers label Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JackKelly