fix(open-next): correctly set cache control for html pages (#353)

jadenv · conico974 · web-flow · commit 186e28f83409 · 2024-02-01T23:49:14.000+01:00
* fix(open-next): correctly set cache control for html pages

* changeset

---------

Co-authored-by: conico974 &lt;nicodorseuil@yahoo.fr&gt;
diff --git a/.changeset/wet-brooms-cheer.md b/.changeset/wet-brooms-cheer.md
@@ -0,0 +1,5 @@
+---
+"open-next": patch
+---
+
+fix(open-next): correctly set cache control for html pages
diff --git a/packages/open-next/src/adapters/plugins/routing/util.ts b/packages/open-next/src/adapters/plugins/routing/util.ts
@@ -74,7 +74,7 @@ export function fixCacheHeaderForHtmlPages(
   headers: Record<string, string | undefined>,
 ) {
   // WORKAROUND: `NextServer` does not set cache headers for HTML pages — https://github.com/serverless-stack/open-next#workaround-nextserver-does-not-set-cache-headers-for-html-pages
-  if (HtmlPages.includes(rawPath) && headers[CommonHeaders.CACHE_CONTROL]) {
+  if (HtmlPages.includes(rawPath)) {
     headers[CommonHeaders.CACHE_CONTROL] =
       "public, max-age=0, s-maxage=31536000, must-revalidate";
   }

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"open-next": patch
 +---
++
 +fix(open-next): correctly set cache control for html pages
Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ export function fixCacheHeaderForHtmlPages(`
`74`	`74`	`headers: Record<string, string \| undefined>,`
`75`	`75`	`) {`
`76`	`76`	// WORKAROUND: `NextServer` does not set cache headers for HTML pages — https://github.com/serverless-stack/open-next#workaround-nextserver-does-not-set-cache-headers-for-html-pages
`77`		`- if (HtmlPages.includes(rawPath) && headers[CommonHeaders.CACHE_CONTROL]) {`
	`77`	`+ if (HtmlPages.includes(rawPath)) {`
`78`	`78`	`headers[CommonHeaders.CACHE_CONTROL] =`
`79`	`79`	`"public, max-age=0, s-maxage=31536000, must-revalidate";`
`80`	`80`	`}`