Skip to content

Commit 7c2b544

Browse files
barbacbdbarbacbd
committed
CORS-4041: Remove the TagManager from the GCP Custom Endpoints
** The tag manager or tagging does appear to have a service in GCP, but this particular one is NOT used. Instead openshift uses the cloud resource manager service, so there is no need to support Tag Manager.
1 parent 6a97aca commit 7c2b544

16 files changed

+2
-19
lines changed

‎config/v1/tests/infrastructures.config.openshift.io/GCPCustomAPIEndpoints.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ tests:
213213
dnsType: PlatformDefault
214214
serviceEndpoints:
215215
- {name: "UnknownService", url: "https://compute-myendpoint1.p.googleapis.com"}
216-
expectedStatusError: "[status.platformStatus.gcp.serviceEndpoints[0].name: Unsupported value: \"UnknownService\": supported values: \"Compute\", \"Container\", \"CloudResourceManager\", \"DNS\", \"File\", \"IAM\", \"ServiceUsage\", \"Storage\", \"TagManager\", <nil>: Invalid value: \"null\": some validation rules were not checked because the object was invalid; correct the existing errors to complete validation"
216+
expectedStatusError: "[status.platformStatus.gcp.serviceEndpoints[0].name: Unsupported value: \"UnknownService\": supported values: \"Compute\", \"Container\", \"CloudResourceManager\", \"DNS\", \"File\", \"IAM\", \"ServiceUsage\", \"Storage\", <nil>: Invalid value: \"null\": some validation rules were not checked because the object was invalid; correct the existing errors to complete validation"
217217
- name: Service Endpoint End Slash
218218
initial: |
219219
apiVersion: config.openshift.io/v1

‎config/v1/types_infrastructure.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -630,7 +630,7 @@ const (
630630
)
631631

632632
// GCPServiceEndpointName is the name of the GCP Service Endpoint.
633-
// +kubebuilder:validation:Enum=Compute;Container;CloudResourceManager;DNS;File;IAM;ServiceUsage;Storage;TagManager
633+
// +kubebuilder:validation:Enum=Compute;Container;CloudResourceManager;DNS;File;IAM;ServiceUsage;Storage
634634
type GCPServiceEndpointName string
635635

636636
const (
@@ -657,9 +657,6 @@ const (
657657

658658
// GCPServiceEndpointNameStorage is the name used for the GCP Storage Service endpoint.
659659
GCPServiceEndpointNameStorage GCPServiceEndpointName = "Storage"
660-
661-
// GCPServiceEndpointNameTagManager is the name used for the GCP Tag Manager Service endpoint.
662-
GCPServiceEndpointNameTagManager GCPServiceEndpointName = "TagManager"
663660
)
664661

665662
// GCPServiceEndpoint store the configuration of a custom url to

‎config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_infrastructures-CustomNoUpgrade.crd.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1917,7 +1917,6 @@ spec:
19171917
- IAM
19181918
- ServiceUsage
19191919
- Storage
1920-
- TagManager
19211920
type: string
19221921
url:
19231922
description: |-

‎config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_infrastructures-DevPreviewNoUpgrade.crd.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1917,7 +1917,6 @@ spec:
19171917
- IAM
19181918
- ServiceUsage
19191919
- Storage
1920-
- TagManager
19211920
type: string
19221921
url:
19231922
description: |-

‎config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_infrastructures-TechPreviewNoUpgrade.crd.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1916,7 +1916,6 @@ spec:
19161916
- IAM
19171917
- ServiceUsage
19181918
- Storage
1919-
- TagManager
19201919
type: string
19211920
url:
19221921
description: |-

‎config/v1/zz_generated.featuregated-crd-manifests/infrastructures.config.openshift.io/GCPCustomAPIEndpoints.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1513,7 +1513,6 @@ spec:
15131513
- IAM
15141514
- ServiceUsage
15151515
- Storage
1516-
- TagManager
15171516
type: string
15181517
url:
15191518
description: |-

‎machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_controllerconfigs-CustomNoUpgrade.crd.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2197,7 +2197,6 @@ spec:
21972197
- IAM
21982198
- ServiceUsage
21992199
- Storage
2200-
- TagManager
22012200
type: string
22022201
url:
22032202
description: |-

‎machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_controllerconfigs-DevPreviewNoUpgrade.crd.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2197,7 +2197,6 @@ spec:
21972197
- IAM
21982198
- ServiceUsage
21992199
- Storage
2200-
- TagManager
22012200
type: string
22022201
url:
22032202
description: |-

‎machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_controllerconfigs-TechPreviewNoUpgrade.crd.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2196,7 +2196,6 @@ spec:
21962196
- IAM
21972197
- ServiceUsage
21982198
- Storage
2199-
- TagManager
22002199
type: string
22012200
url:
22022201
description: |-

‎machineconfiguration/v1/zz_generated.featuregated-crd-manifests/controllerconfigs.machineconfiguration.openshift.io/GCPCustomAPIEndpoints.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1811,7 +1811,6 @@ spec:
18111811
- IAM
18121812
- ServiceUsage
18131813
- Storage
1814-
- TagManager
18151814
type: string
18161815
url:
18171816
description: |-

‎payload-manifests/crds/0000_10_config-operator_01_infrastructures-CustomNoUpgrade.crd.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1917,7 +1917,6 @@ spec:
19171917
- IAM
19181918
- ServiceUsage
19191919
- Storage
1920-
- TagManager
19211920
type: string
19221921
url:
19231922
description: |-

‎payload-manifests/crds/0000_10_config-operator_01_infrastructures-DevPreviewNoUpgrade.crd.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1917,7 +1917,6 @@ spec:
19171917
- IAM
19181918
- ServiceUsage
19191919
- Storage
1920-
- TagManager
19211920
type: string
19221921
url:
19231922
description: |-

‎payload-manifests/crds/0000_10_config-operator_01_infrastructures-TechPreviewNoUpgrade.crd.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1916,7 +1916,6 @@ spec:
19161916
- IAM
19171917
- ServiceUsage
19181918
- Storage
1919-
- TagManager
19201919
type: string
19211920
url:
19221921
description: |-

‎payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-CustomNoUpgrade.crd.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2197,7 +2197,6 @@ spec:
21972197
- IAM
21982198
- ServiceUsage
21992199
- Storage
2200-
- TagManager
22012200
type: string
22022201
url:
22032202
description: |-

‎payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-DevPreviewNoUpgrade.crd.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2197,7 +2197,6 @@ spec:
21972197
- IAM
21982198
- ServiceUsage
21992199
- Storage
2200-
- TagManager
22012200
type: string
22022201
url:
22032202
description: |-

‎payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-TechPreviewNoUpgrade.crd.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2196,7 +2196,6 @@ spec:
21962196
- IAM
21972197
- ServiceUsage
21982198
- Storage
2199-
- TagManager
22002199
type: string
22012200
url:
22022201
description: |-

0 commit comments

Comments
 (0)