OCPBUGS-28230: enforce termination message policy on all platform pods

Author: deads2k

manifests/0000_50_olm_06-psm-operator.deployment.ibm-cloud-managed.yaml

@@ -52,7 +52,7 @@ spec:
               memory: 20Mi
               cpu: 10m
           terminationMessagePath: /dev/termination-log
-          terminationMessagePolicy: File
+          terminationMessagePolicy: FallbackToLogsOnError
           volumeMounts:
             - mountPath: /etc/tls/private
               name: package-server-manager-serving-cert

manifests/0000_50_olm_06-psm-operator.deployment.yaml

@@ -51,7 +51,7 @@ spec:
               memory: 20Mi
               cpu: 10m
           terminationMessagePath: /dev/termination-log
-          terminationMessagePolicy: File
+          terminationMessagePolicy: FallbackToLogsOnError
           volumeMounts:
             - mountPath: /etc/tls/private
               name: package-server-manager-serving-cert

manifests/0000_50_olm_07-collect-profiles.cronjob.yaml

@@ -52,6 +52,7 @@ spec:
                 requests:
                   cpu: 10m
                   memory: 80Mi
+              terminationMessagePolicy: FallbackToLogsOnError
           volumes:
             - name: config-volume
               configMap:

staging/operator-lifecycle-manager/pkg/controller/bundle/bundle_unpacker.go

@@ -157,6 +157,7 @@ func (c *ConfigMapUnpacker) job(cmRef *corev1.ObjectReference, bundlePath string
 									Drop: []corev1.Capability{"ALL"},
 								},
 							},
+							TerminationMessagePolicy: corev1.TerminationMessageFallbackToLogsOnError,
 						},
 					},
 					InitContainers: []corev1.Container{
@@ -182,6 +183,7 @@ func (c *ConfigMapUnpacker) job(cmRef *corev1.ObjectReference, bundlePath string
 									Drop: []corev1.Capability{"ALL"},
 								},
 							},
+							TerminationMessagePolicy: corev1.TerminationMessageFallbackToLogsOnError,
 						},
 						{
 							Name:            "pull",
@@ -210,6 +212,7 @@ func (c *ConfigMapUnpacker) job(cmRef *corev1.ObjectReference, bundlePath string
 									Drop: []corev1.Capability{"ALL"},
 								},
 							},
+							TerminationMessagePolicy: corev1.TerminationMessageFallbackToLogsOnError,
 						},
 					},
 					Volumes: []corev1.Volume{

staging/operator-lifecycle-manager/pkg/controller/registry/reconciler/reconciler.go

@@ -279,11 +279,12 @@ func Pod(source *operatorsv1alpha1.CatalogSource, name, opmImg, utilImage, img s
 				MountPath: catalogPath,
 			}
 			pod.Spec.InitContainers = append(pod.Spec.InitContainers, corev1.Container{
-				Name:         "extract-utilities",
-				Image:        utilImage,
-				Command:      []string{"cp"},
-				Args:         []string{"/bin/copy-content", fmt.Sprintf("%s/copy-content", utilitiesPath)},
-				VolumeMounts: []corev1.VolumeMount{utilitiesVolumeMount},
+				Name:                     "extract-utilities",
+				Image:                    utilImage,
+				Command:                  []string{"cp"},
+				Args:                     []string{"/bin/copy-content", fmt.Sprintf("%s/copy-content", utilitiesPath)},
+				VolumeMounts:             []corev1.VolumeMount{utilitiesVolumeMount},
+				TerminationMessagePolicy: corev1.TerminationMessageFallbackToLogsOnError,
 			}, corev1.Container{
 				Name:            "extract-content",
 				Image:           img,
@@ -295,7 +296,8 @@ func Pod(source *operatorsv1alpha1.CatalogSource, name, opmImg, utilImage, img s
 					"--cache.from=" + grpcPodConfig.ExtractContent.CacheDir,
 					"--cache.to=" + fmt.Sprintf("%s/cache", catalogPath),
 				},
-				VolumeMounts: []corev1.VolumeMount{utilitiesVolumeMount, contentVolumeMount},
+				VolumeMounts:             []corev1.VolumeMount{utilitiesVolumeMount, contentVolumeMount},
+				TerminationMessagePolicy: corev1.TerminationMessageFallbackToLogsOnError,
 			})
 
 			pod.Spec.Containers[0].Image = opmImg