PR feedback optimizations

Author: jakedoublev

service/internal/subjectmappingbuiltin/subject_mapping_builtin_actions.go

@@ -2,6 +2,7 @@ package subjectmappingbuiltin
 
 import (
 	"fmt"
+	"maps"
 	"slices"
 	"strings"
 
@@ -19,7 +20,7 @@ func EvaluateSubjectMappingMultipleEntitiesWithActions(
 	attributeMappings map[string]*attributes.GetAttributeValuesByFqnsResponse_AttributeAndValue,
 	entityRepresentations []*entityresolutionV2.EntityRepresentation,
 ) (EntityIDsToEntitlements, error) {
-	results := make(map[string]AttributeValueFQNsToActions)
+	results := make(map[string]AttributeValueFQNsToActions, len(entityRepresentations))
 	for _, er := range entityRepresentations {
 		entitlements, err := EvaluateSubjectMappingsWithActions(attributeMappings, er)
 		if err != nil {
@@ -71,13 +72,12 @@ func EvaluateSubjectMappingsWithActions(
 					actions := subjectMapping.GetActions()
 
 					// Cache each action by name to deduplicate
+					m := make(map[string]*policy.Action, len(actions))
 					for _, action := range actions {
-						if !slices.ContainsFunc(entitlementsSet[valueFQN], func(a *policy.Action) bool {
-							return strings.EqualFold(a.GetName(), action.GetName())
-						}) {
-							entitlementsSet[valueFQN] = append(entitlementsSet[valueFQN], action)
-						}
+						m[strings.ToLower(action.GetName())] = action
+
 					}
+					entitlementsSet[valueFQN] = append(entitlementsSet[valueFQN], slices.Collect(maps.Values(m))...)
 				}
 			}
 		}