Skip to content

Commit c545b56

Browse files
committed
presume FQN is populated in response with upstream PR #2151
1 parent fe42878 commit c545b56

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed

service/internal/access/v2/pdp.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,6 @@ func (p *PDP) fetchEntitleableAttributes(ctx context.Context, entityRepresentati
267267
}
268268
mapped.Value.SubjectMappings = make([]*policy.SubjectMapping, 0)
269269
mapped.Value.SubjectMappings = append(mapped.Value.SubjectMappings, mapping)
270-
// TODO: make sure the FQN is present here
271270
result[mapping.GetAttributeValue().GetFqn()] = mapped
272271
}
273272
return result, nil

service/policy/db/query.sql

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1244,7 +1244,6 @@ SELECT
12441244
'id', scs.id,
12451245
'subject_sets', scs.condition
12461246
) AS subject_condition_set,
1247-
-- TODO: make sure value fqn is queried here
12481247
JSON_BUILD_OBJECT('id', av.id,'value', av.value,'active', av.active) AS attribute_value
12491248
FROM subject_mappings sm
12501249
LEFT JOIN attribute_values av ON sm.attribute_value_id = av.id

0 commit comments

Comments
 (0)