-
Notifications
You must be signed in to change notification settings - Fork 24
fix(policy): deprecates and reserves value members from value object in protos #1151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning This pull request does not reference any issues. Please add a reference to an issue in the body of the pull request description. |
Blocked by #1291 which is causing CI failure |
jrschumacher
reviewed
Aug 9, 2024
jrschumacher
reviewed
Aug 9, 2024
jrschumacher
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work and reserving
This was referenced Aug 9, 2024
This was referenced Aug 9, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.11](protocol/go/v0.2.10...protocol/go/v0.2.11) (2024-08-12) ### Features * **authz:** Typed Entities ([#1249](#1249)) ([cfab3ad](cfab3ad)) * **policy:** 1277 add Resource Mapping Group to objects proto ([#1309](#1309)) ([514f1b8](514f1b8)), closes [#1277](#1277) ### Bug Fixes * **core:** bump golang.org/x/net from 0.22.0 to 0.23.0 in /protocol/go ([#627](#627)) ([6008320](6008320)) * **kas:** Regenerate protos and fix tests from info rpc removal ([#1291](#1291)) ([91a2fe6](91a2fe6)) * **policy:** deprecates and reserves value members from value object in protos ([#1151](#1151)) ([07fcc9e](07fcc9e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.18](service/v0.4.17...service/v0.4.18) (2024-08-12) ### Features * **authz:** Remove external ers configuration from authorization ([#1265](#1265)) ([aa925a8](aa925a8)) * **authz:** Typed Entities ([#1249](#1249)) ([cfab3ad](cfab3ad)) * **core:** ability to run a set of isolated services ([#1245](#1245)) ([aa5636a](aa5636a)) * **core:** improve entitlements performance ([#1271](#1271)) ([f6a1b26](f6a1b26)) * **core:** policy support for LIST of kas grants (protos/db) ([#1317](#1317)) ([599fc56](599fc56)) * **core:** Simplifies support for kidless clients ([#1272](#1272)) ([dedeb32](dedeb32)) * **policy:** 1256 resource mapping groups db support ([#1270](#1270)) ([c020e9b](c020e9b)) * **policy:** 1277 add Resource Mapping Group to objects proto ([#1309](#1309)) ([514f1b8](514f1b8)), closes [#1277](#1277) ### Bug Fixes * **core:** Autobump service ([#1322](#1322)) ([9460fb5](9460fb5)) * **core:** casbin policy should support assign/remove/deactivate rpc naming ([#1298](#1298)) ([288921b](288921b)), closes [#1303](#1303) * **core:** put back proto breaking change detection in CI ([#1292](#1292)) ([9921962](9921962)), closes [#1293](#1293) * **core:** Update casbin policy for rewrap with unknown role ([#1305](#1305)) ([de5be3c](de5be3c)) * **policy:** deprecates and reserves value members from value object in protos ([#1151](#1151)) ([07fcc9e](07fcc9e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to ADR #984
Resolves #1095
Acceptance Criteria from issue:
members
from values database CRUDmembers
from attributes database CRUD (if any)members
members