Skip to content

Asynctest replacement #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewwhitehead opened this issue Apr 6, 2022 · 1 comment · Fixed by #2566
Closed

Asynctest replacement #1717

andrewwhitehead opened this issue Apr 6, 2022 · 1 comment · Fixed by #2566
Labels
dependencies Pull requests that update a dependency file help wanted Extra attention is needed

Comments

@andrewwhitehead
Copy link
Contributor

The asynctest library which we use extensively in unit tests is no longer being maintained, and does not function properly under Python 3.8+.

Coincidentally, Python 3.8 with mock 4.0 introduces some tools (IsolatedAsyncioTestCase and AsyncMock) which might be sufficient to replace it. It looks like there is a backwards-compatible stub which could be required for testing in Python 3.6 and 3.7.

There would be some changes required to all async test cases (using asyncSetUp instead of async def setUp for example), and we will probably want to try porting some more advanced test cases first in order to check if any other features of asynctest are required.

@swcurran swcurran added the help wanted Extra attention is needed label Jun 3, 2022
@swcurran
Copy link
Contributor

swcurran commented Jun 3, 2022

For anyone wanting to contributing and to get a good view on the scope of ACA-Py, this would be a good task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants