Skip to content

Commit 565ea74

Browse files
committed
chore(docs): fix javadoc issue
1 parent 9679f89 commit 565ea74

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/Controller.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,17 @@
1717
/**
1818
* Optional finalizer name, if it is not, the crdName will be used as the name of the finalizer
1919
* too.
20+
*
21+
* @return the finalizer name
2022
*/
2123
String finalizerName() default NULL;
2224

2325
/**
2426
* If true, will dispatch new event to the controller if generation increased since the last
2527
* processing, otherwise will process all events. See generation meta attribute <a
2628
* href="https://kubernetes.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definitions/#status-subresource">here</a>
29+
*
30+
* @return whether the controller takes generation into account to process events
2731
*/
2832
boolean generationAwareEventProcessing() default true;
2933

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/ResourceController.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ public interface ResourceController<R extends CustomResource> {
1313
* to have the implementation also idempotent, in the current implementation to cover all edge
1414
* cases actually will be executed mostly twice.
1515
*
16-
* @param resource
16+
* @param resource the resource that is marked for deletion
17+
* @param context the context with which the operation is executed
1718
* @return {@link DeleteControl#DEFAULT_DELETE} - so the finalizer is automatically removed after
1819
* the call. {@link DeleteControl#NO_FINALIZER_REMOVAL} if you don't want to remove the
1920
* finalizer. Note that this is ALMOST NEVER the case.
@@ -27,6 +28,8 @@ default DeleteControl deleteResource(R resource, Context<R> context) {
2728
* object to make updates on custom resource if possible. Also always use the custom resource
2829
* parameter (not the custom resource that might be in the events)
2930
*
31+
* @param resource the resource that has been created or updated
32+
* @param context the context with which the operation is executed
3033
* @return The resource is updated in api server if the return value is not {@link
3134
* UpdateControl#noUpdate()}. This the common use cases. However in cases, for example the
3235
* operator is restarted, and we don't want to have an update call to k8s api to be made
@@ -39,7 +42,8 @@ default DeleteControl deleteResource(R resource, Context<R> context) {
3942
/**
4043
* In init typically you might want to register event sources.
4144
*
42-
* @param eventSourceManager
45+
* @param eventSourceManager the {@link EventSourceManager} which handles this controller and with
46+
* which event sources can be registered
4347
*/
4448
default void init(EventSourceManager eventSourceManager) {}
4549
}

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventSourceManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public interface EventSourceManager extends Closeable {
1111
*
1212
* @param name the name of the {@link EventSource} to add
1313
* @param eventSource the {@link EventSource} to register
14-
* @thorw IllegalStateException if an {@link EventSource} with the same name is already
14+
* @throws IllegalStateException if an {@link EventSource} with the same name is already
1515
* registered.
1616
*/
1717
void registerEventSource(String name, EventSource eventSource);

0 commit comments

Comments
 (0)