improve: make sure there is no infinite recursion by default for external service (#2130)

Signed-off-by: Attila Mészáros <[email protected]>

Author: csviri

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/AbstractDependentResource.java

@@ -85,9 +85,7 @@ protected ReconcileResult<R> reconcile(P primary, R actualResource, Context<P> c
     return ReconcileResult.noOperation(actualResource);
   }
 
-  public Result<R> match(R resource, P primary, Context<P> context) {
-    return updater.match(resource, primary, context);
-  }
+  public abstract Result<R> match(R resource, P primary, Context<P> context);
 
   @Override
   public Optional<R> getSecondaryResource(P primary, Context<P> context) {

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/AbstractExternalDependentResource.java

@@ -76,6 +76,11 @@ protected void handleExplicitStateCreation(P primary, R created, Context<P> cont
     }
   }
 
+  @Override
+  public Matcher.Result<R> match(R resource, P primary, Context<P> context) {
+    var desired = desired(primary, context);
+    return Matcher.Result.computed(resource.equals(desired), desired);
+  }
 
   @SuppressWarnings("unchecked")
   public void deleteTargetResource(P primary, R resource, String key,