Skip to content

Define Event Sources Using @ControllerConfiguration Annotation #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
csviri opened this issue Jun 22, 2022 · 1 comment
Closed

Define Event Sources Using @ControllerConfiguration Annotation #1298

csviri opened this issue Jun 22, 2022 · 1 comment
Assignees
Labels

Comments

@csviri
Copy link
Collaborator

csviri commented Jun 22, 2022

It would be elegant to define event sources using annotations (just as we define dependent resources).

Proposed design for annotation would look like this:

@ControllerConfiguration(
    eventSources = @EventSources(informers = @Informer(resourceType = ConfigMap.class,
        followNamespaceChanges = true),others = @EventSource(type = MyPollingEventSource.class)))
public class SampleReconciler

where @Informer annotation would have most of the configurations, that could be defined by the config builder:
see: https://github.com/java-operator-sdk/java-operator-sdk/blob/6fd141fe1c3922fed11995814a222bcce446b015/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/Informer.java

Notes:

  • these event sources won't be subject of configuration override.
@csviri csviri added the feature label Jun 22, 2022
@csviri csviri self-assigned this Jun 22, 2022
@csviri csviri added this to the 3.1 milestone Jun 22, 2022
@csviri csviri linked a pull request Jun 29, 2022 that will close this issue
@csviri csviri modified the milestones: 3.1, 3.2 Jul 13, 2022
@csviri csviri removed this from the 3.2 milestone Aug 26, 2022
@csviri
Copy link
Collaborator Author

csviri commented Apr 26, 2024

We agreed that this won't be supported for now.

@csviri csviri closed this as completed Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant