Skip to content

Remove Optional to Access Results in ManagedDependentResourceContext #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
csviri opened this issue May 30, 2023 · 3 comments · Fixed by #2212
Closed

Remove Optional to Access Results in ManagedDependentResourceContext #1925

csviri opened this issue May 30, 2023 · 3 comments · Fixed by #2212
Labels
api-changes-epic kind/feature Categorizes issue or PR as related to a new feature.
Milestone
5.0

Comments

@csviri
Copy link
Collaborator

csviri commented May 30, 2023 •
edited
Loading

https://github.com/java-operator-sdk/java-operator-sdk/blob/3280f69dbe85cf3baeb268de6f095c1ab3721498/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/dependent/managed/ManagedDependentResourceContext.java#L55-L57

Those does not make that much sense, since naturally these methods are only called when managed dependent resources are used. And this is not a decision for runtime. It should just throw an exception if these results are accessed but managed dependent resources are not initialized.
@csviri csviri added kind/feature Categorizes issue or PR as related to a new feature. api-changes-epic labels May 30, 2023
@csviri csviri added this to the 5.0 milestone May 30, 2023
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Jul 30, 2023
@csviri csviri removed the stale label Jul 30, 2023
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Sep 29, 2023
@csviri csviri removed the stale label Oct 2, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Dec 2, 2023
@csviri csviri removed the stale label Dec 4, 2023
@csviri csviri linked a pull request Jan 22, 2024 that will close this issue
improve: managed dependent reconciliation results not optional #2212
Merged
@csviri csviri closed this as completed Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api-changes-epic kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
5.0
Development

Successfully merging a pull request may close this issue.

improve: managed dependent reconciliation results not optional operator-framework/java-operator-sdk
1 participant
@csviri