Misleading warnings in AbstractWorkflowExecutor

[kosmoz]

Bug Report

When upgrading the Java Operator SDK to 4.6, I noticed some warnings that I did not see before. I believe these warnings are false positives and were introduced on accident when activation conditions were implemented.

What did you do?

1. Have a reconciler with one managed DR
2. Start operator
3. Create resource

What did you expect to see?

No warning.

What did you see instead? Under which circumstances?

The following warning is logged once for each reconciliation of the primary resource:

WARN  i.j.o.p.d.w.WorkflowReconcileExecutor - Notified but still resources under execution. This should not happen.

Environment

Kubernetes cluster type:

vanilla

$ Mention java-operator-sdk version from pom.xml file

4.6.1

$ java -version

openjdk version "17.0.9" 2023-10-17
OpenJDK Runtime Environment (Red_Hat-17.0.9.0.9-2) (build 17.0.9+9)
OpenJDK 64-Bit Server VM (Red_Hat-17.0.9.0.9-2) (build 17.0.9+9, mixed mode, sharing)

$ kubectl version

Client Version: v1.28.4
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.27.3

Possible Solution

When activation conditions were implemented, waitForScheduledExecutionsToRun needed to be changed because it had become possible that no executions were scheduled to begin with. To achieve this, the invocation of this.wait() was simply moved to after where noMoreExecutionsScheduled() is checked (see dcbf7d6#diff-42a60986a7e5e09307320e6bb6473cc5e8db0af1fefc502079936802982a8953). The problem, from what I understand, is that it must be expected that noMoreExecutionsScheduled() returns false before wait() has been called at least once. Because it probably makes sense to keep the warning, I think a possible solution would be to keep the contents of the while loop as it was before this change and check noMoreExecutionsScheduled() an additional time before entering the loop (without logging a warning if it returns false).

Additional context

[csviri]

Exactly @kosmoz , thank you! attached the PR

[kosmoz]

Thanks for the quick solution! 🙂

[csviri]

Thanks for the quick solution! 🙂

Np, just did what you told me to do :) :P