From 11e3eb582b295e30d56fdaee5c3e95dbf047adc2 Mon Sep 17 00:00:00 2001 From: csviri Date: Fri, 28 Jul 2023 10:28:59 +0200 Subject: [PATCH 1/2] fix: logging whole resource just on trace level In case of Secrets this migh log sensitice data. --- .../processing/dependent/AbstractDependentResource.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/AbstractDependentResource.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/AbstractDependentResource.java index 64d877a563..1d14db9236 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/AbstractDependentResource.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/AbstractDependentResource.java @@ -108,7 +108,7 @@ private void logForOperation(String operation, P primary, R desired) { + ((HasMetadata) desired).getKind() : desired.getClass().getSimpleName(); log.info("{} {} for primary {}", operation, desiredDesc, ResourceID.fromResource(primary)); - log.debug("{} dependent {} for primary {}", operation, desired, primary); + log.trace("{} dependent {} for primary {}", operation, desired, primary); } protected R handleCreate(R desired, P primary, Context

context) { From 7560e347788be909db9334b42cf9918694d5ad65 Mon Sep 17 00:00:00 2001 From: csviri Date: Mon, 31 Jul 2023 09:22:31 +0200 Subject: [PATCH 2/2] logging removed --- .../processing/dependent/AbstractDependentResource.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/AbstractDependentResource.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/AbstractDependentResource.java index 1d14db9236..897664e08a 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/AbstractDependentResource.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/AbstractDependentResource.java @@ -107,8 +107,7 @@ private void logForOperation(String operation, P primary, R desired) { ? "'" + ((HasMetadata) desired).getMetadata().getName() + "' " + ((HasMetadata) desired).getKind() : desired.getClass().getSimpleName(); - log.info("{} {} for primary {}", operation, desiredDesc, ResourceID.fromResource(primary)); - log.trace("{} dependent {} for primary {}", operation, desired, primary); + log.debug("{} {} for primary {}", operation, desiredDesc, ResourceID.fromResource(primary)); } protected R handleCreate(R desired, P primary, Context

context) {