From 3cd53da68dd7347bfca709fb42922936131d6308 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Attila=20M=C3=A9sz=C3=A1ros?= Date: Mon, 28 Oct 2024 08:43:51 +0100 Subject: [PATCH 1/3] docs: withKubernetesClient improved docs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Attila Mészáros --- .../operator/api/config/ConfigurationServiceOverrider.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java index 83894eaa61..b55bf56fe4 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java @@ -11,6 +11,7 @@ import io.fabric8.kubernetes.api.model.HasMetadata; import io.fabric8.kubernetes.client.KubernetesClient; +import io.javaoperatorsdk.operator.Operator; import io.javaoperatorsdk.operator.api.monitoring.Metrics; import io.javaoperatorsdk.operator.api.reconciler.dependent.DependentResourceFactory; @@ -121,6 +122,10 @@ public ConfigurationServiceOverrider withWorkflowExecutorService( /** * Replaces the default {@link KubernetesClient} instance by the specified one. This is the * preferred mechanism to configure which client will be used to access the cluster. + *

+ * Note that when {@link Operator#stop()} is called, by default the client is closed even if + * explicitly provided with this method. Use {@link #withKubernetesClient(KubernetesClient)} to + * change this behavior. * * @param client the fully configured client to use for cluster access * @return this {@link ConfigurationServiceOverrider} for chained customization From 01c9cc322721e5718442bd71b52e89677ee68342 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Attila=20M=C3=A9sz=C3=A1ros?= Date: Mon, 28 Oct 2024 09:16:32 +0100 Subject: [PATCH 2/3] fix method MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Attila Mészáros --- .../operator/api/config/ConfigurationServiceOverrider.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java index b55bf56fe4..1b16ab2978 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java @@ -124,7 +124,7 @@ public ConfigurationServiceOverrider withWorkflowExecutorService( * preferred mechanism to configure which client will be used to access the cluster. *

* Note that when {@link Operator#stop()} is called, by default the client is closed even if - * explicitly provided with this method. Use {@link #withKubernetesClient(KubernetesClient)} to + * explicitly provided with this method. Use {@link #withCloseClientOnStop(boolean)} to * change this behavior. * * @param client the fully configured client to use for cluster access From 6aae975be22258619e9efafb572c075968d60439 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Attila=20M=C3=A9sz=C3=A1ros?= Date: Mon, 28 Oct 2024 10:15:19 +0100 Subject: [PATCH 3/3] format MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Attila Mészáros --- .../operator/api/config/ConfigurationServiceOverrider.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java index 1b16ab2978..62cebad77a 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java @@ -124,8 +124,8 @@ public ConfigurationServiceOverrider withWorkflowExecutorService( * preferred mechanism to configure which client will be used to access the cluster. *

* Note that when {@link Operator#stop()} is called, by default the client is closed even if - * explicitly provided with this method. Use {@link #withCloseClientOnStop(boolean)} to - * change this behavior. + * explicitly provided with this method. Use {@link #withCloseClientOnStop(boolean)} to change + * this behavior. * * @param client the fully configured client to use for cluster access * @return this {@link ConfigurationServiceOverrider} for chained customization