Removes unnecessary HaveLen assertions

Mikalai Radchuk · m1kola · commit 0b824909dce1 · 2023-06-27T09:53:54.000+01:00
Signed-off-by: Mikalai Radchuk &lt;mradchuk@redhat.com&gt;
diff --git a/internal/resolution/variable_sources/bundlesanddependencies/bundles_and_dependencies_test.go b/internal/resolution/variable_sources/bundlesanddependencies/bundles_and_dependencies_test.go
@@ -199,7 +199,6 @@ var _ = Describe("BundlesAndDepsVariableSource", func() {
 				bundleVariables = append(bundleVariables, v)
 			}
 		}
-		Expect(bundleVariables).To(HaveLen(12))
 		Expect(bundleVariables).To(WithTransform(CollectBundleVariableIDs, Equal([]string{"bundle-2", "bundle-1", "bundle-15", "bundle-16", "bundle-17", "bundle-9", "bundle-8", "bundle-7", "bundle-5", "bundle-4", "bundle-11", "bundle-10"})))
 
 		// check dependencies for one of the bundles
diff --git a/internal/resolution/variable_sources/crdconstraints/crd_constraints_test.go b/internal/resolution/variable_sources/crdconstraints/crd_constraints_test.go
@@ -247,8 +247,7 @@ var _ = Describe("CRDUniquenessConstraintsVariableSource", func() {
 				crdConstraintVariables = append(crdConstraintVariables, v)
 			}
 		}
-		Expect(crdConstraintVariables).To(HaveLen(11))
-		Expect(crdConstraintVariables).To(WithTransform(CollectGlobalConstraintVariableIDs, ContainElements([]string{
+		Expect(crdConstraintVariables).To(WithTransform(CollectGlobalConstraintVariableIDs, ConsistOf([]string{
 			"another-package package uniqueness",
 			"bar-package package uniqueness",
 			"test-package-2 package uniqueness",

Original file line number	Diff line number	Diff line change
`@@ -199,7 +199,6 @@ var _ = Describe("BundlesAndDepsVariableSource", func() {`
`199`	`199`	`bundleVariables = append(bundleVariables, v)`
`200`	`200`	`}`
`201`	`201`	`}`
`202`		`- Expect(bundleVariables).To(HaveLen(12))`
`203`	`202`	`Expect(bundleVariables).To(WithTransform(CollectBundleVariableIDs, Equal([]string{"bundle-2", "bundle-1", "bundle-15", "bundle-16", "bundle-17", "bundle-9", "bundle-8", "bundle-7", "bundle-5", "bundle-4", "bundle-11", "bundle-10"})))`
`204`	`203`
`205`	`204`	`// check dependencies for one of the bundles`
Original file line number	Diff line number	Diff line change
`@@ -247,8 +247,7 @@ var _ = Describe("CRDUniquenessConstraintsVariableSource", func() {`
`247`	`247`	`crdConstraintVariables = append(crdConstraintVariables, v)`
`248`	`248`	`}`
`249`	`249`	`}`
`250`		`- Expect(crdConstraintVariables).To(HaveLen(11))`
`251`		`- Expect(crdConstraintVariables).To(WithTransform(CollectGlobalConstraintVariableIDs, ContainElements([]string{`
	`250`	`+ Expect(crdConstraintVariables).To(WithTransform(CollectGlobalConstraintVariableIDs, ConsistOf([]string{`
`252`	`251`	`"another-package package uniqueness",`
`253`	`252`	`"bar-package package uniqueness",`
`254`	`253`	`"test-package-2 package uniqueness",`