fix: improved Makefile (#210)

- adds check for go-lint and statik before installing
- renamed install target to setup to avoid confusion
- updated README.md to reflect changes

Author: juancarlostong

.travis.yml

@@ -132,4 +132,4 @@ jobs:
 before_script:
   # https://github.com/travis-ci/gimme
   - eval "$(gimme)"
-  - make -e install build
+  - make -e setup build

Makefile

@@ -49,9 +49,13 @@ cover: check-go static ## runs test suite with coverage profiling
 cover-html: cover ## generates test coverage html report
 	$(GOCMD) tool cover -html=$(COVER_FILE)
 
-install: check-go ## installs all dev and ci dependencies, but does not install golang
+setup: check-go ## installs all dev and ci dependencies, but does not install golang
+ifeq (,$(wildcard $(GOLINT)))
 	curl -sfL https://github.com/raw/golangci/golangci-lint/master/install.sh| sh -s -- -b $(GOPATH)/bin v1.19.0
+endif
+ifeq (,$(wildcard $(GOPATH)/bin/statik))
 	go get github.com/rakyll/statik
+endif
 
 lint: check-go static ## runs `golangci-lint` linters defined in `.golangci.yml` file
 	$(GOLINT) run --out-format=tab --tests=false ./...

README.md

@@ -19,7 +19,7 @@ Installers and binary archives for most platforms can be downloaded directly fro
 ## Running from source (Linux / OSX)
 Once Go is installed, the Optimizely Agent can be started via the following `make` command:
 ```bash
-make install
+make setup
 make run
 ```
 This will start the Optimizely Agent with the default configuration in the foreground.

scripts/dockerfiles/Dockerfile.alpine

@@ -4,8 +4,7 @@ FROM golang:$GO_VERSION-alpine3.10 as builder
 RUN apk add --no-cache make gcc libc-dev git
 WORKDIR /go/src/github.com/optimizely/agent
 COPY . .
-RUN make install
-RUN make build
+RUN make setup build
 
 FROM alpine:3.10
 RUN apk add --no-cache ca-certificates=20190108-r0

scripts/dockerfiles/Dockerfile.static

@@ -3,7 +3,7 @@ FROM golang:$GO_VERSION as builder
 
 WORKDIR /go/src/github.com/optimizely/agent
 COPY . .
-RUN make install build
+RUN make setup build
 RUN make ci_build_static_binary
 
 FROM scratch