From e17f988dcf087b4b47e116a03ff888ebba9ca0f3 Mon Sep 17 00:00:00 2001 From: Thomas Zurkan Date: Fri, 16 Aug 2019 14:06:53 -0700 Subject: [PATCH] fix so that the job service will not run if there is no internet connection (possibly causing ANR). Also, start job right away so for instance events are flushed faster (another customer request --- .../com/optimizely/ab/android/shared/ServiceScheduler.java | 3 ++- test-app/src/main/AndroidManifest.xml | 6 ++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/shared/src/main/java/com/optimizely/ab/android/shared/ServiceScheduler.java b/shared/src/main/java/com/optimizely/ab/android/shared/ServiceScheduler.java index 81a26706a..210cffd80 100644 --- a/shared/src/main/java/com/optimizely/ab/android/shared/ServiceScheduler.java +++ b/shared/src/main/java/com/optimizely/ab/android/shared/ServiceScheduler.java @@ -270,7 +270,8 @@ public static void startService(Context context, Integer jobId, Intent intent) { JobInfo jobInfo = new JobInfo.Builder(jobId, new ComponentName(context, JobWorkService.class)) // schedule it to run any time between 1 - 5 minutes - .setMinimumLatency(JobWorkService.ONE_MINUTE) + .setMinimumLatency(0) + .setRequiredNetworkType(JobInfo.NETWORK_TYPE_ANY) .setOverrideDeadline(5 * JobWorkService.ONE_MINUTE) .build(); JobScheduler jobScheduler = (JobScheduler) context.getSystemService(Context.JOB_SCHEDULER_SERVICE); diff --git a/test-app/src/main/AndroidManifest.xml b/test-app/src/main/AndroidManifest.xml index 5ad8bdc1f..f495e2e7d 100644 --- a/test-app/src/main/AndroidManifest.xml +++ b/test-app/src/main/AndroidManifest.xml @@ -18,7 +18,8 @@ --> + xmlns:tools="http://schemas.android.com/tools" + package="com.optimizely.ab.android.test_app"> @@ -31,7 +32,8 @@ android:icon="@mipmap/ic_launcher" android:label="@string/app_name" android:supportsRtl="true" - android:theme="@style/AppTheme"> + android:theme="@style/AppTheme" + tools:ignore="GoogleAppIndexingWarning">