Skip to content

Commit 1e896cc

Browse files
committed
Change variation_key to '' instead of null in metadata
1 parent d1e1f9a commit 1e896cc

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

packages/optimizely-sdk/lib/core/event_builder/index.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,12 @@ function getImpressionEventParams(configObj, experimentId, variationId, ruleKey,
103103
if (experimentId !== null) {
104104
campaignId = projectConfig.getLayerId(configObj, experimentId);
105105
}
106+
107+
let variationKey = projectConfig.getVariationKeyFromId(configObj, variationId);
108+
if (variationKey === null) {
109+
variationKey = '';
110+
}
111+
106112
var impressionEventParams = {
107113
decisions: [
108114
{
@@ -113,7 +119,7 @@ function getImpressionEventParams(configObj, experimentId, variationId, ruleKey,
113119
flag_key: flagKey,
114120
rule_key: ruleKey,
115121
rule_type: ruleType,
116-
variation_key: projectConfig.getVariationKeyFromId(configObj, variationId),
122+
variation_key: variationKey,
117123
}
118124
},
119125
],

packages/optimizely-sdk/lib/core/project_config/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ export var getExperimentAudienceConditions = function(projectConfig, experimentK
279279
* Get variation key given experiment key and variation ID
280280
* @param {Object} projectConfig Object representing project configuration
281281
* @param {string} variationId ID of the variation
282-
* @return {string} Variation key or null if the variation ID is not found
282+
* @return {string|null} Variation key or null if the variation ID is not found
283283
*/
284284
export var getVariationKeyFromId = function(projectConfig, variationId) {
285285
if (projectConfig.variationIdMap.hasOwnProperty(variationId)) {

0 commit comments

Comments
 (0)