Introduce NeverInlineTrivial option and fix -H:TrackDynamicAccess=all gathering entries from non-application class and module paths

Author: jormundur00

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/SubstrateOptions.java

@@ -913,6 +913,9 @@ public static long getTearDownFailureNanos() {
     @Option(help = "file:doc-files/NeverInlineHelp.txt", type = OptionType.Debug)//
     public static final HostedOptionKey<AccumulatingLocatableMultiOptionValue.Strings> NeverInline = new HostedOptionKey<>(AccumulatingLocatableMultiOptionValue.Strings.build());
 
+    @Option(help = "Never trivially inline provided methods. Uses the same method pattern syntax as the 'NeverInline' option.") public static final HostedOptionKey<AccumulatingLocatableMultiOptionValue.Strings> NeverInlineTrivial = new HostedOptionKey<>(
+                    AccumulatingLocatableMultiOptionValue.Strings.build());
+
     @Option(help = "Maximum number of nodes in a method so that it is considered trivial.")//
     public static final HostedOptionKey<Integer> MaxNodesInTrivialMethod = new HostedOptionKey<>(20);
 

substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/DynamicAccessDetectionFeature.java

@@ -99,7 +99,7 @@ public ConcurrentLinkedQueue<String> getMethodCallLocations(String methodName) {
         }
     }
 
-    private static final Set<String> neverInlineMethods = Set.of(
+    private static final Set<String> neverInlineTrivialMethods = Set.of(
                     "java.lang.invoke.MethodHandles$Lookup.unreflectGetter",
                     "java.lang.invoke.MethodHandles$Lookup.unreflectSetter",
                     "java.io.ObjectInputStream.readObject",
@@ -108,7 +108,6 @@ public ConcurrentLinkedQueue<String> getMethodCallLocations(String methodName) {
                     "java.lang.ClassLoader.loadClass",
                     "java.lang.foreign.Linker.nativeLinker");
 
-    public static final String GRAAL_SUBPATH = File.separator + "graal" + File.separator;
     public static final String TRACK_ALL = "all";
 
     private static final String OUTPUT_DIR_NAME = "dynamic-access";
@@ -364,8 +363,8 @@ public static void parseDynamicAccessOptions(EconomicMap<OptionKey<?>, Object> h
             }
         });
         if (!classLoaderSupport.dynamicAccessSelectorsEmpty()) {
-            for (String method : neverInlineMethods) {
-                SubstrateOptions.NeverInline.update(hostedValues, method);
+            for (String method : neverInlineTrivialMethods) {
+                SubstrateOptions.NeverInlineTrivial.update(hostedValues, method);
             }
         }
     }

substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/NativeImageClassLoaderSupport.java

@@ -1180,14 +1180,8 @@ public void setPreserveAll(ValueWithOrigin<String> valueWithOrigin) {
 
     public void setTrackAllDynamicAccess(ValueWithOrigin<String> valueWithOrigin) {
         var origin = new IncludeOptionsSupport.ExtendedOptionWithOrigin(new IncludeOptionsSupport.ExtendedOption("", DynamicAccessDetectionFeature.TRACK_ALL), valueWithOrigin);
-        classpath().stream()
-                        .map(Path::toString)
-                        .filter(path -> !path.contains(DynamicAccessDetectionFeature.GRAAL_SUBPATH))
-                        .forEach(entry -> dynamicAccessSelectors.addClassPathEntry(entry, origin));
-        modulepath().stream()
-                        .map(Path::toString)
-                        .filter(path -> !path.contains(DynamicAccessDetectionFeature.GRAAL_SUBPATH))
-                        .forEach(entry -> dynamicAccessSelectors.addModule(entry, origin));
+        getModulePathsFinder().findAll().forEach(m -> dynamicAccessSelectors.addModule(m.descriptor().name(), origin));
+        dynamicAccessSelectors.addModule(ALL_UNNAMED, origin);
     }
 
     public Stream<Class<?>> getClassesToIncludeUnconditionally() {

substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/SVMHost.java

@@ -829,7 +829,9 @@ public boolean hasNeverInlineDirective(ResolvedJavaMethod method) {
             return false;
         }
 
-        return SubstrateOptions.NeverInline.getValue().values().stream().anyMatch(re -> MethodFilter.parse(re).matches(method));
+        return SubstrateOptions.NeverInline.getValue().values().stream()
+                        .map(MethodFilter::parse)
+                        .anyMatch(filter -> filter.matches(method));
     }
 
     private InlineBeforeAnalysisPolicy inlineBeforeAnalysisPolicy(MultiMethod.MultiMethodKey multiMethodKey) {
@@ -1108,7 +1110,10 @@ public boolean neverInlineTrivial(AnalysisMethod caller, AnalysisMethod callee)
                 return true;
             }
         }
-        return false;
+        if (!SubstrateOptions.NeverInlineTrivial.hasBeenSet()) {
+            return false;
+        }
+        return SubstrateOptions.NeverInlineTrivial.getValue().values().stream().anyMatch(re -> MethodFilter.parse(re).matches(callee));
     }
 
     private static boolean shouldEvaluateNeverInlineTrivialOnlyWith(Class<?>[] onlyWith) {