-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Proposition - Node 12 support #1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Node 12 is not in LTS until October 22nd, there are dozen of features and other things that would be just as beneficial if not more. I'd say let's wait until Node12 has matured a bit, and yes I am excited about the performance changes that it has promised. |
The work with N-API referenced in issue #1053 will work with Node.js 12 without any changes. Take a look there if you are eager! |
I (currently) have no plans to release node-oracledb 3 binaries for Node 12. Convince me otherwise. Early adopters can build the module binary easily enough, and/or build the dev-4.0 branch. |
Heh, a new NAN would be needed for v3. |
Node 12 has one amazing feature. Error stacktrace containing the trace of asynchronous calls. |
Now would be a good time for you to build the amazing-and-will-be-more-amazing node-oracledb 4 dev code and give us some feedback. |
@danilohgds @cjbj What about support for ECMAScript Modules so we can |
@riyadshauk See this: #501 (comment) |
@riyadshauk I just ran a test and I was able to get it working. Here are the steps:
|
Perhaps this should be documented... if someone submits a PR :) |
It's time for Node 12.
The text was updated successfully, but these errors were encountered: