Skip to content

Proposition - Node 12 support #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sosoba opened this issue Apr 23, 2019 · 10 comments
Closed

Proposition - Node 12 support #1085

sosoba opened this issue Apr 23, 2019 · 10 comments

Comments

@sosoba
Copy link

sosoba commented Apr 23, 2019

It's time for Node 12.

@danilohgds
Copy link

Node 12 is not in LTS until October 22nd, there are dozen of features and other things that would be just as beneficial if not more.

I'd say let's wait until Node12 has matured a bit, and yes I am excited about the performance changes that it has promised.

@anthony-tuininga
Copy link
Member

The work with N-API referenced in issue #1053 will work with Node.js 12 without any changes. Take a look there if you are eager!

@cjbj
Copy link
Member

cjbj commented Apr 23, 2019

I (currently) have no plans to release node-oracledb 3 binaries for Node 12. Convince me otherwise. Early adopters can build the module binary easily enough, and/or build the dev-4.0 branch.

@cjbj cjbj closed this as completed Apr 23, 2019
@cjbj
Copy link
Member

cjbj commented Apr 23, 2019

Heh, a new NAN would be needed for v3.

@sosoba
Copy link
Author

sosoba commented Apr 24, 2019

I (currently) have no plans to release node-oracledb 3 binaries for Node 12. Convince me otherwise.

Node 12 has one amazing feature. Error stacktrace containing the trace of asynchronous calls.

@cjbj
Copy link
Member

cjbj commented Apr 24, 2019

Now would be a good time for you to build the amazing-and-will-be-more-amazing node-oracledb 4 dev code and give us some feedback.

@riyadshauk
Copy link

riyadshauk commented Apr 25, 2019

@danilohgds @cjbj What about support for ECMAScript Modules so we can import this library? ...I also ran npm install oracle/node-oracledb#dev-4.0, as @cjbj talked about in the above link.

@dmcghan
Copy link

dmcghan commented Apr 25, 2019

@riyadshauk See this: #501 (comment)

@dmcghan
Copy link

dmcghan commented Apr 25, 2019

@riyadshauk I just ran a test and I was able to get it working. Here are the steps:

  1. In your module, use this:
    import oracledb from 'oracledb';
  2. Make sure your module file has the extension .mjs.
  3. Run your module with the experimental-modules flag:
    node --experimental-modules main.mjs

@cjbj
Copy link
Member

cjbj commented Apr 26, 2019

Perhaps this should be documented... if someone submits a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants