Skip to content

Add angular highlighting for $element and $attributes #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tandrewnichols opened this issue Sep 7, 2016 · 2 comments
Closed

Add angular highlighting for $element and $attributes #55

tandrewnichols opened this issue Sep 7, 2016 · 2 comments

Comments

@tandrewnichols
Copy link

The list of built-in services in #1 is fairly complete, but in directives, there are also $element and $attributes that can be injected. $element is just a jQuery object, so it wouldn't have any methods attached to it that would need to be highlighted (if jQuery highlighting is already turned on). $attributes has a few methods, however. From the docs here: $normalize, $addClass, $removeClass, $updateClass, $observe, $set, and $attr. (That last is actually just a property and not a function.) Any chance similar highlighting could be added to these things as is on the built-in services (e.g. $scope.$eval)?

@tandrewnichols
Copy link
Author

Example (non-)highlighting:

screen shot 34

$scope is highlighted, but $attributes and $observe are not.

@othree othree closed this as completed in 2aba8f4 Sep 30, 2016
@tandrewnichols
Copy link
Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant