Add run-tests and setup-pandas actions

Author: jonashaag

.github/actions/build_pandas/action.yml

@@ -8,6 +8,8 @@ runs:
       run: |
         conda info
         conda list
+        # Make sure we have the correct environment activated
+        conda info | grep -Ei 'environment.+:' | grep -qEiv 'environment.+:.+none'
       shell: bash -el {0}
 
     - name: Build Pandas
@@ -18,3 +20,7 @@ runs:
       env:
         # Cannot use parallel compilation on Windows, see https://github.com/pandas-dev/pandas/issues/30873
         N_JOBS: ${{ runner.os == 'Windows' && 1 || 2 }}
+
+    - name: Show dependency versions
+      run: python -c "import pandas; pandas.show_versions()"
+      shell: bash -el {0}

.github/actions/run-tests/action.yml

@@ -0,0 +1,41 @@
+name: Run tests and report results
+description: >-
+  Runs the test suite and publishes the results and coverage.
+
+  Pandas is expected to be installed with pip or Conda in a way that a Python
+  interpreter run from a login bash will be able to import it, eg.
+  `bash -lc 'python -c "import pandas"'`.
+inputs:
+  check-pyarrow-version:
+    description: >-
+      If set, double-check that the PyArrow version used by the Pandas installation
+      if identical to this string.
+    required: false
+runs:
+  using: composite
+  steps:
+    - name: Check PyArrow version
+      run: |
+        # Double check that we have the expected PyArrow
+        mamba list -f pyarrow | grep ${{ inputs.check-pyarrow-version }}
+      shell: bash -el {0}
+      if: ${{ inputs.check-pyarrow-version }}
+
+    - name: Test
+      run: ci/run_tests.sh
+      shell: bash -el {0}
+
+    - name: Publish test results
+      uses: actions/upload-artifact@v2
+      with:
+        name: Test results
+        path: test-data.xml
+      if: failure()
+
+    - name: Upload coverage to Codecov
+      uses: codecov/codecov-action@v2
+      with:
+        flags: unittests
+        name: codecov-pandas
+        fail_ci_if_error: false
+      if: failure()

.github/actions/setup-pandas/action.yml

@@ -0,0 +1,33 @@
+name: Set up pandas
+description: Runs all the setup steps required to have a built pandas ready to use
+inputs:
+  environment-file:
+    description: Conda environment file to use.
+    default: environment.yml
+  pyarrow-version:
+    description: If set, overrides the PyArrow version in the Conda environment to the given string.
+    required: false
+runs:
+  using: composite
+  steps:
+    - name: Set Arrow version in ${{ inputs.environment-file }} to ${{ inputs.pyarrow-version }}
+      run: |
+        grep -q '  - pyarrow' ${{ inputs.environment-file }}
+        sed -i"" -e "s/  - pyarrow/  - pyarrow=${{ inputs.pyarrow-version }}/" ${{ inputs.environment-file }}
+        cat ${{ inputs.environment-file }}
+      shell: bash
+      if: ${{ inputs.pyarrow-version }}
+
+    - name: Pin setuptools (GH#44980)
+      run: |
+        echo '  - setuptools <60' >> ${{ inputs.environment-file }}
+      shell: bash
+
+    - name: Install ${{ inputs.environment-file }}
+      uses: conda-incubator/setup-miniconda@v2
+      with:
+        environment-file: ${{ inputs.environment-file }}
+        channel-priority: ${{ runner.os == 'macOS' && 'flexible' || 'strict' }}
+        channels: conda-forge
+        mamba-version: "0.23"
+        use-mamba: true

.github/workflows/macos-windows.yml

@@ -43,42 +43,16 @@ jobs:
       with:
         fetch-depth: 0
 
-    - name: Install Dependencies
-      uses: conda-incubator/setup-[email protected]
+    - name: Set up Conda (${{ matrix.env_file }}, Arrow ${{ matrix.pyarrow_version}})
+      uses: ./.github/actions/setup-pandas
       with:
-        mamba-version: "*"
-        channels: conda-forge
-        activate-environment: pandas-dev
-        channel-priority: ${{ matrix.os == 'macos-latest' && 'flexible' || 'strict' }}
         environment-file: ci/deps/${{ matrix.env_file }}
-        use-only-tar-bz2: true
+        pyarrow-version: ${{ matrix.os == 'macos-latest' && '6' || '' }}
 
-    # ImportError: 2): Library not loaded: @rpath/libssl.1.1.dylib
-    # Referenced from: /Users/runner/miniconda3/envs/pandas-dev/lib/libthrift.0.13.0.dylib
-    # Reason: image not found
-    - name: Upgrade pyarrow on MacOS
-      run: conda install -n pandas-dev -c conda-forge --no-update-deps pyarrow=6
-      if: ${{ matrix.os == 'macos-latest' }}
-
-    - name: Build Pandas
+    - name: Build pandas
       uses: ./.github/actions/build_pandas
 
-    - name: Test
-      run: ci/run_tests.sh
-
-    - name: Build Version
-      run: conda list
-
-    - name: Publish test results
-      uses: actions/upload-artifact@v3
-      with:
-        name: Test results
-        path: test-data.xml
-      if: failure()
-
-    - name: Upload coverage to Codecov
-      uses: codecov/codecov-action@v2
+    - name: Run tests
+      uses: ./.github/actions/run-tests
       with:
-        flags: unittests
-        name: codecov-pandas
-        fail_ci_if_error: false
+        check-pyarrow-version: ${{ matrix.pyarrow_version }}

setup.py

@@ -333,7 +333,7 @@ def run(self):
         extra_compile_args.append("/Z7")
         extra_link_args.append("/DEBUG")
 else:
-    # PANDAS_CI=1 is set by ci/setup_env.sh
+    # PANDAS_CI=1 is set in CI
     if os.environ.get("PANDAS_CI", "0") == "1":
         extra_compile_args.append("-Werror")
     if debugging_symbols_requested: