Skip to content

Commit 7037713

Browse files
committed
adjust for comments
1 parent b2761c6 commit 7037713

File tree

3 files changed

+9
-14
lines changed

3 files changed

+9
-14
lines changed

pandas/core/indexes/multi.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ def __new__(
259259
result._set_levels(levels, copy=copy, validate=False)
260260
result._set_codes(codes, copy=copy, validate=False)
261261

262-
result._names = [None for _ in levels]
262+
result._names = [None] * len(levels)
263263
if names is not None:
264264
# handles name validation
265265
result._set_names(names)

pandas/core/reshape/reshape.py

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -260,13 +260,10 @@ def get_new_values(self):
260260
def get_new_columns(self):
261261
if self.value_columns is None:
262262
if self.lift == 0:
263-
lev = self.removed_level._shallow_copy()
264-
lev.name = self.removed_name
265-
return lev
263+
return self.removed_level._shallow_copy(name=self.removed_name)
266264

267265
lev = self.removed_level.insert(0, item=self.removed_level._na_value)
268-
lev.name = self.removed_name
269-
return lev
266+
return lev.rename(self.removed_name)
270267

271268
stride = len(self.removed_level) + self.lift
272269
width = len(self.value_columns)
@@ -302,12 +299,10 @@ def get_new_index(self):
302299

303300
# construct the new index
304301
if len(self.new_index_levels) == 1:
305-
lev, lab = self.new_index_levels[0], result_codes[0]
306-
if (lab == -1).any():
307-
lev = lev.insert(len(lev), lev._na_value)
308-
new_index = lev.take(lab)
309-
new_index.name = self.new_index_names[0]
310-
return new_index
302+
level, level_codes = self.new_index_levels[0], result_codes[0]
303+
if (level_codes == -1).any():
304+
level = level.insert(len(level), level._na_value)
305+
return level.take(level_codes).rename(self.new_index_names[0])
311306

312307
return MultiIndex(
313308
levels=self.new_index_levels,
@@ -663,8 +658,7 @@ def _convert_level_number(level_num, columns):
663658
new_names = this.columns.names[:-1]
664659
new_columns = MultiIndex.from_tuples(unique_groups, names=new_names)
665660
else:
666-
new_columns = this.columns.levels[0]._shallow_copy()
667-
new_columns.name = this.columns.names[0]
661+
new_columns = this.columns.levels[0]._shallow_copy(name=this.columns.names[0])
668662
unique_groups = new_columns
669663

670664
# time to ravel the values

pandas/tests/frame/test_alter_axes.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -980,6 +980,7 @@ def test_reset_index(self, float_frame):
980980
values = lev.take(level_codes)
981981
name = names[i]
982982
tm.assert_index_equal(values, Index(deleveled[name]), check_names=False)
983+
assert values.name is None
983984

984985
stacked.index.names = [None, None]
985986
deleveled2 = stacked.reset_index()

0 commit comments

Comments
 (0)