Skip to content

Commit 9ffc438

Browse files
Backport PR #54789 on branch 2.1.x (WARN: Remove non-actionable warning in value_counts) (#54795)
Backport PR #54789: WARN: Remove non-actionable warning in value_counts Co-authored-by: Patrick Hoefler <[email protected]>
1 parent d27c467 commit 9ffc438

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

pandas/core/frame.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7260,7 +7260,7 @@ def value_counts(
72607260
subset = self.columns.tolist()
72617261

72627262
name = "proportion" if normalize else "count"
7263-
counts = self.groupby(subset, dropna=dropna).grouper.size()
7263+
counts = self.groupby(subset, dropna=dropna, observed=False).grouper.size()
72647264
counts.name = name
72657265

72667266
if sort:

pandas/tests/frame/methods/test_value_counts.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,3 +175,17 @@ def test_data_frame_value_counts_subset(nulls_fixture, columns):
175175
)
176176

177177
tm.assert_series_equal(result, expected)
178+
179+
180+
def test_value_counts_categorical_future_warning():
181+
# GH#54775
182+
df = pd.DataFrame({"a": [1, 2, 3]}, dtype="category")
183+
result = df.value_counts()
184+
expected = pd.Series(
185+
1,
186+
index=pd.MultiIndex.from_arrays(
187+
[pd.Index([1, 2, 3], name="a", dtype="category")]
188+
),
189+
name="count",
190+
)
191+
tm.assert_series_equal(result, expected)

0 commit comments

Comments
 (0)