Skip to content

Commit cda39a6

Browse files
committed
refine syntax in Series rename method, and add docstring to validate_bool_kwarg
1 parent 379acb3 commit cda39a6

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

pandas/core/series.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -2355,10 +2355,8 @@ def align(self, other, join='outer', axis=None, level=None, copy=True,
23552355

23562356
@Appender(generic._shared_docs['rename'] % _shared_doc_kwargs)
23572357
def rename(self, index=None, **kwargs):
2358-
if 'inplace' in kwargs:
2359-
kwargs['inplace'] = validate_bool_kwarg(kwargs['inplace'], 'inplace')
2360-
else:
2361-
kwargs['inplace'] = False
2358+
kwargs['inplace'] = validate_bool_kwarg(kwargs.get('inplace', False),
2359+
'inplace')
23622360

23632361
non_mapping = is_scalar(index) or (is_list_like(index) and
23642362
not is_dict_like(index))

pandas/util/validators.py

+1
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,7 @@ def validate_args_and_kwargs(fname, args, kwargs,
217217
validate_kwargs(fname, kwargs, compat_args)
218218

219219
def validate_bool_kwarg(value, arg_name):
220+
""" Ensures that argument passed in arg_name is of type bool. """
220221
if not (is_bool(value) or value is None):
221222
raise ValueError('For argument "%s" expected type bool, ' % arg_name +\
222223
'received type %s.' % type(value).__name__)

0 commit comments

Comments
 (0)