feedback: test roundtrip

arw2019 · arw2019 · commit f70368b0b631 · 2020-10-09T15:33:49.000Z
diff --git a/pandas/tests/indexing/test_categorical.py b/pandas/tests/indexing/test_categorical.py
@@ -660,8 +660,6 @@ def test_reindexing_with_missing_values(self):
         data = {"col": range(len(index))}
         df = DataFrame(data=data, index=index)
 
-        res = df.reset_index()
-
         expected = pd.DataFrame(
             {
                 "level_0": pd.Categorical.from_codes(
@@ -674,6 +672,11 @@ def test_reindexing_with_missing_values(self):
             }
         )
 
+        res = df.reset_index()
+        tm.assert_frame_equal(res, expected)
+
+        # roundtrip
+        res = expected.set_index(["level_0", "level_1"]).reset_index()
         tm.assert_frame_equal(res, expected)
 
     def test_loc_and_at_with_categorical_index(self):

Original file line number	Diff line number	Diff line change
`@@ -660,8 +660,6 @@ def test_reindexing_with_missing_values(self):`
`660`	`660`	`data = {"col": range(len(index))}`
`661`	`661`	`df = DataFrame(data=data, index=index)`
`662`	`662`
`663`		`- res = df.reset_index()`
`664`		`-`
`665`	`663`	`expected = pd.DataFrame(`
`666`	`664`	`{`
`667`	`665`	`"level_0": pd.Categorical.from_codes(`
`@@ -674,6 +672,11 @@ def test_reindexing_with_missing_values(self):`
`674`	`672`	`}`
`675`	`673`	`)`
`676`	`674`
	`675`	`+ res = df.reset_index()`
	`676`	`+ tm.assert_frame_equal(res, expected)`
	`677`	`+`
	`678`	`+ # roundtrip`
	`679`	`+ res = expected.set_index(["level_0", "level_1"]).reset_index()`
`677`	`680`	`tm.assert_frame_equal(res, expected)`
`678`	`681`
`679`	`682`	`def test_loc_and_at_with_categorical_index(self):`