Skip to content

pre-commit check for flake8 doesn't check Cython code #30843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xhochy opened this issue Jan 9, 2020 · 0 comments · Fixed by #30847
Closed

pre-commit check for flake8 doesn't check Cython code #30843

xhochy opened this issue Jan 9, 2020 · 0 comments · Fixed by #30847
Labels
CI Continuous Integration Code Style Code style, linting, code_checks
Milestone
1.1

Comments

@xhochy
Copy link
Contributor

xhochy commented Jan 9, 2020

Currently the check only matches .py files. Cython files aren't checked.
@xhochy xhochy mentioned this issue Jan 9, 2020
Merged
5 tasks
@gfyoung gfyoung added Code Style Code style, linting, code_checks CI Continuous Integration labels Jan 10, 2020
@jreback jreback added this to the 1.1 milestone Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

BLD: Run flake8 check on Cython files in pre-commit xhochy/pandas
3 participants
@xhochy @jreback @gfyoung