Skip to content

REF: do length-checks in boilerplate decorator #34233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
charlesdong1991 opened this issue May 18, 2020 · 2 comments
Closed

REF: do length-checks in boilerplate decorator #34233

charlesdong1991 opened this issue May 18, 2020 · 2 comments
Labels
Refactor Internal refactoring of code

Comments

@charlesdong1991
Copy link
Member

charlesdong1991 commented May 18, 2020 •
edited
Loading

The PR #34081 was reverted due to its impact on length-checks in Index special cases with tuples.

And the refactor is still nice for the cleanup but needs to have appropriate changes to avoid this issue.
@charlesdong1991 charlesdong1991 added Needs Triage Issue that has not been reviewed by a pandas team member Usage Question Refactor Internal refactoring of code and removed Needs Triage Issue that has not been reviewed by a pandas team member Usage Question labels May 18, 2020
@charlesdong1991 charlesdong1991 mentioned this issue May 18, 2020
Merged
@jorisvandenbossche
Copy link
Member

Relevant issue about this: #27911

@mroeschke
Copy link
Member

We can consider this as a subpoint to #27911, so closing in favor of consolidating there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Refactor Internal refactoring of code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jorisvandenbossche @charlesdong1991 @mroeschke