Skip to content

DOC: fixup link for lookup example #39863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarcoGorelli opened this issue Feb 17, 2021 · 4 comments · Fixed by #39869
Closed

DOC: fixup link for lookup example #39863

MarcoGorelli opened this issue Feb 17, 2021 · 4 comments · Fixed by #39869

Comments

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Feb 17, 2021

Location of the documentation

https://pandas.pydata.org/pandas-docs/dev/reference/api/pandas.DataFrame.lookup.html?highlight=lookup#pandas.DataFrame.lookup

Documentation problem

It says

For an example see lookup() in the user guide.

but the hyperlink doesn't send to the user guide

Suggested fix for documentation

link to https://pandas.pydata.org/pandas-docs/stable/user_guide/indexing.html#looking-up-values-by-index-column-labels instead

@morrme
Copy link
Contributor

morrme commented Feb 17, 2021

Since it can be a little challenging for newcomers to find the relevant files (see #39859 ), the affected files/lines are:

For an example see :meth:`~pandas.DataFrame.lookup`

https://github.com/pandas-dev/pandas/blob/master/doc/source/user_guide/indexing.rst#looking-up-values-by-indexcolumn-labels

@MarcoGorelli
Copy link
Member Author

Thanks @morrme

Just to be clear, this issue can be done independently of #39859

@morrme
Copy link
Contributor

morrme commented Feb 17, 2021

Thanks @morrme

Just to be clear, this issue can be done independently of #39859

Updated my comment for clarity. 🙂

@MarcoGorelli
Copy link
Member Author

Thanks :)

Since it can be a little challenging to find the relevant files (see #39859

Though in this case, wouldn't the [source] button already give you the file location?

image

@simonjayhawkins simonjayhawkins added this to the 1.2.3 milestone Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants