Skip to content

DOC: Add note about git fetch upstream --tags to contributing guide #56475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
WillAyd opened this issue Dec 12, 2023 · 2 comments
Closed
1 task done

DOC: Add note about git fetch upstream --tags to contributing guide #56475

WillAyd opened this issue Dec 12, 2023 · 2 comments

Comments

@WillAyd
Copy link
Member

WillAyd commented Dec 12, 2023

Pandas version checks

  • I have checked that the issue still exists on the latest versions of the docs on main here

Location of the documentation

https://pandas.pydata.org/pandas-docs/stable/development/contributing_environment.html#

Documentation problem

If you are working from an old fork that doesn't sync tags with pandas upstream, versioneer will install pandas with a really old version tag which other dependencies like pyarrow don't like

Suggested fix for documentation

Add a note that users may want to run git fetch upstream --tags before installing

@WillAyd WillAyd added Docs Needs Triage Issue that has not been reviewed by a pandas team member labels Dec 12, 2023
@lithomas1 lithomas1 added good first issue and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Dec 18, 2023
@MaanavS16
Copy link

MaanavS16 commented Dec 19, 2023

There already appears to be a note mentioning the need for git fetch upstream --tags

70f90b7
#54618

@WillAyd
Copy link
Member Author

WillAyd commented Dec 19, 2023

Ah thanks @MaanavS16 I think that covers this

@WillAyd WillAyd closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants