From bee7140244aa1138aca167895c9645e76160f787 Mon Sep 17 00:00:00 2001 From: Guillaume Lemaitre Date: Sun, 2 Feb 2020 13:11:52 +0100 Subject: [PATCH 1/4] DOC fix *_option() docstring --- pandas/_config/config.py | 1 + 1 file changed, 1 insertion(+) diff --git a/pandas/_config/config.py b/pandas/_config/config.py index cacd6f5454de7..67e75e2e1577c 100644 --- a/pandas/_config/config.py +++ b/pandas/_config/config.py @@ -158,6 +158,7 @@ def _describe_option(pat: str = "", _print_desc: bool = True): s = "" for k in keys: # filter by pat s += _build_option_description(k) + s += "\n" if _print_desc: print(s) From 001fbadc2edf3ca4adeeac6f5c427a3c758b3f0e Mon Sep 17 00:00:00 2001 From: Guillaume Lemaitre Date: Sun, 2 Feb 2020 14:10:12 +0100 Subject: [PATCH 2/4] iter --- pandas/_config/config.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pandas/_config/config.py b/pandas/_config/config.py index 67e75e2e1577c..9cf1ac906c780 100644 --- a/pandas/_config/config.py +++ b/pandas/_config/config.py @@ -159,6 +159,8 @@ def _describe_option(pat: str = "", _print_desc: bool = True): for k in keys: # filter by pat s += _build_option_description(k) s += "\n" + # strip the last newline + s = s[:s.rfind("\n")] if _print_desc: print(s) From 2787ea1541cc5c6790946c30394d9ea2516aa204 Mon Sep 17 00:00:00 2001 From: Guillaume Lemaitre Date: Sun, 2 Feb 2020 14:55:56 +0100 Subject: [PATCH 3/4] black style --- pandas/_config/config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/_config/config.py b/pandas/_config/config.py index 9cf1ac906c780..598a6a59e6063 100644 --- a/pandas/_config/config.py +++ b/pandas/_config/config.py @@ -160,7 +160,7 @@ def _describe_option(pat: str = "", _print_desc: bool = True): s += _build_option_description(k) s += "\n" # strip the last newline - s = s[:s.rfind("\n")] + s = s[: s.rfind("\n")] if _print_desc: print(s) From 1881fb9ad2cee9b690c63b3a1c00575e5cd2e903 Mon Sep 17 00:00:00 2001 From: Guillaume Lemaitre Date: Mon, 3 Feb 2020 10:41:08 +0100 Subject: [PATCH 4/4] address joris comments --- pandas/_config/config.py | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/pandas/_config/config.py b/pandas/_config/config.py index 598a6a59e6063..8b6116d3abd60 100644 --- a/pandas/_config/config.py +++ b/pandas/_config/config.py @@ -155,12 +155,7 @@ def _describe_option(pat: str = "", _print_desc: bool = True): if len(keys) == 0: raise OptionError("No such keys(s)") - s = "" - for k in keys: # filter by pat - s += _build_option_description(k) - s += "\n" - # strip the last newline - s = s[: s.rfind("\n")] + s = "\n".join([_build_option_description(k) for k in keys]) if _print_desc: print(s)