Skip to content

Conversation

SkymanOne
Copy link
Contributor

@SkymanOne SkymanOne commented Feb 5, 2024

Summary

Closes #_

  • y/n | Does it introduce breaking changes?
  • y/n | Is it dependant on the specific version of cargo-contract or pallet-contracts?

Description

Removed additiona_contracts parameters from ink_e2e::test macro as this info is implied from the contract's manifest

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have added an entry to CHANGELOG.md
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please also check the 5.x docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants