Skip to content

Commit c95cc4b

Browse files
authored
replace kIsWeb with its definition (#415)
Using less libaries is always good.
1 parent 23f911e commit c95cc4b

7 files changed

+13
-9
lines changed

lib/parse_server_sdk.dart

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import 'dart:typed_data';
88
import 'dart:ui' as ui;
99

1010
import 'package:devicelocale/devicelocale.dart';
11-
import 'package:flutter/foundation.dart' show kIsWeb;
1211
import 'package:http/http.dart';
1312
import 'package:http/io_client.dart';
1413
import 'package:meta/meta.dart';

lib/src/base/parse_constants.dart

+2
Original file line numberDiff line numberDiff line change
@@ -81,3 +81,5 @@ const String keyVarInstallationId = 'installationId';
8181
// Error
8282
const String keyError = 'error';
8383
const String keyCode = 'code';
84+
85+
const bool parseIsWeb = identical(0, 0.0);

lib/src/data/parse_core_data.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ class ParseCoreData {
6363
if (liveListRetryIntervals != null) {
6464
_instance.liveListRetryIntervals = liveListRetryIntervals;
6565
} else {
66-
_instance.liveListRetryIntervals = kIsWeb
66+
_instance.liveListRetryIntervals = parseIsWeb
6767
? <int>[0, 500, 1000, 2000, 5000]
6868
: <int>[0, 500, 1000, 2000, 5000, 10000];
6969
}

lib/src/data/parse_subclass_handler.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class ParseSubClassHandler {
2222
Map<String, ParseObjectConstructor> _subClassMap;
2323
ParseUserConstructor _parseUserConstructor;
2424
ParseFileConstructor _parseFileConstructor = ({String name, String url}) {
25-
if (kIsWeb) {
25+
if (parseIsWeb) {
2626
return ParseWebFile(null, name: name, url: url);
2727
} else {
2828
return ParseFile(null, name: name, url: url);

lib/src/objects/parse_installation.dart

+5-3
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ class ParseInstallation extends ParseObject {
6868
/// Updates the installation with current device data
6969
Future<void> _updateInstallation() async {
7070
//Device type
71-
if (kIsWeb) {
71+
if (parseIsWeb) {
7272
set<String>(keyDeviceType, 'web');
7373
} else if (Platform.isAndroid) {
7474
set<String>(keyDeviceType, 'android');
@@ -83,15 +83,17 @@ class ParseInstallation extends ParseObject {
8383
}
8484

8585
//Locale
86-
final String locale = kIsWeb ? ui.window.locale.toString() : await Devicelocale.currentLocale;
86+
final String locale = parseIsWeb
87+
? ui.window.locale.toString()
88+
: await Devicelocale.currentLocale;
8789
if (locale != null && locale.isNotEmpty) {
8890
set<String>(keyLocaleIdentifier, locale);
8991
}
9092

9193
//Timezone
9294

9395
//App info
94-
if (!kIsWeb) {
96+
if (!parseIsWeb) {
9597
final PackageInfo packageInfo = await PackageInfo.fromPlatform();
9698
set<String>(keyAppName, packageInfo.appName);
9799
set<String>(keyAppVersion, packageInfo.version);

lib/src/storage/core_store_sem_impl.dart

+2-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ class CoreStoreSembastImp implements CoreStore {
1212
factory ??= databaseFactoryIo;
1313
final SembastCodec codec = getXXTeaSembastCodec(password: password);
1414
String dbDirectory = '';
15-
if (!kIsWeb && (Platform.isIOS || Platform.isAndroid || Platform.isMacOS))
15+
if (!parseIsWeb &&
16+
(Platform.isIOS || Platform.isAndroid || Platform.isMacOS))
1617
dbDirectory = (await getApplicationDocumentsDirectory()).path;
1718
final String dbPath = path.join('$dbDirectory/parse', 'parse.db');
1819
final Database db = await factory.openDatabase(dbPath, codec: codec);

lib/src/utils/parse_utils.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ String removeTrailingSlash(String serverUrl) {
6565
}
6666
}
6767

68-
Future<ParseResponse> batchRequest(List<dynamic> requests,
69-
List<ParseObject> objects,
68+
Future<ParseResponse> batchRequest(
69+
List<dynamic> requests, List<ParseObject> objects,
7070
{ParseHTTPClient client, bool debug}) async {
7171
debug = isDebugEnabled(objectLevelDebug: debug);
7272
client = client ??

0 commit comments

Comments
 (0)